mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-05-02 12:19:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

Reduce allocation of temporary values on heap.

Browse Source 
- Use `std::move` while inserting temporary results into vectors.
- Change `push_back` to `emplace_back` where appropriate.
This commit is contained in:
Pavel Solodovnikov
2018-01-25 16:59:33 +03:00
parent fa3ac83af0
commit c85bb007df
69 changed files with 303 additions and 315 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmComputeTargetDepends.cxx
+6 -7
View File
@@ -200,7 +200,7 @@ void cmComputeTargetDepends::CollectTargetDepends(int depender_index)
std::vector<std::string> configs;
depender->Makefile->GetConfigurations(configs);
if (configs.empty()) {
configs.push_back("");
configs.emplace_back();
}
for (std::string const& it : configs) {
std::vector<cmSourceFile const*> objectFiles;
@@ -369,8 +369,7 @@ void cmComputeTargetDepends::AddTargetDepend(int depender_index,
int dependee_index = tii->second;
// Add this entry to the dependency graph.
this->InitialGraph[depender_index].push_back(
cmGraphEdge(dependee_index, !linking));
this->InitialGraph[depender_index].emplace_back(dependee_index, !linking);
}
}
@@ -504,7 +503,7 @@ bool cmComputeTargetDepends::IntraComponent(std::vector<int> const& cmap,
for (cmGraphEdge const& edge : el) {
int j = edge;
if (cmap[j] == c && edge.IsStrong()) {
this->FinalGraph[i].push_back(cmGraphEdge(j, true));
this->FinalGraph[i].emplace_back(j, true);
if (!this->IntraComponent(cmap, c, j, head, emitted, visited)) {
return false;
}
@@ -513,7 +512,7 @@ bool cmComputeTargetDepends::IntraComponent(std::vector<int> const& cmap,
// Prepend to a linear linked-list of intra-component edges.
if (*head >= 0) {
this->FinalGraph[i].push_back(cmGraphEdge(*head, false));
this->FinalGraph[i].emplace_back(*head, false);
} else {
this->ComponentTail[c] = i;
}
@@ -563,8 +562,8 @@ bool cmComputeTargetDepends::ComputeFinalDepends(
for (cmGraphEdge const& ni : nl) {
int dependee_component = ni;
int dependee_component_head = this->ComponentHead[dependee_component];
this->FinalGraph[depender_component_tail].push_back(
cmGraphEdge(dependee_component_head, ni.IsStrong()));
this->FinalGraph[depender_component_tail].emplace_back(
dependee_component_head, ni.IsStrong());
}
}
return true;