mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-05-08 07:10:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

Reduce allocation of temporary values on heap.

Browse Source 
- Use `std::move` while inserting temporary results into vectors.
- Change `push_back` to `emplace_back` where appropriate.
This commit is contained in:
Pavel Solodovnikov
2018-01-25 16:59:33 +03:00
parent fa3ac83af0
commit c85bb007df
69 changed files with 303 additions and 315 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmGeneratorExpressionLexer.cxx
+6 -10
View File
@@ -12,8 +12,7 @@ static void InsertText(const char* upto, const char* c,
std::vector<cmGeneratorExpressionToken>& result)
{
if (upto != c) {
result.push_back(cmGeneratorExpressionToken(
cmGeneratorExpressionToken::Text, upto, c - upto));
result.emplace_back(cmGeneratorExpressionToken::Text, upto, c - upto);
}
}
@@ -30,8 +29,8 @@ std::vector<cmGeneratorExpressionToken> cmGeneratorExpressionLexer::Tokenize(
case '$':
if (c[1] == '<') {
InsertText(upto, c, result);
result.push_back(cmGeneratorExpressionToken(
cmGeneratorExpressionToken::BeginExpression, c, 2));
result.emplace_back(cmGeneratorExpressionToken::BeginExpression, c,
2);
upto = c + 2;
++c;
SawBeginExpression = true;
@@ -39,21 +38,18 @@ std::vector<cmGeneratorExpressionToken> cmGeneratorExpressionLexer::Tokenize(
break;
case '>':
InsertText(upto, c, result);
result.push_back(cmGeneratorExpressionToken(
cmGeneratorExpressionToken::EndExpression, c, 1));
result.emplace_back(cmGeneratorExpressionToken::EndExpression, c, 1);
upto = c + 1;
SawGeneratorExpression = SawBeginExpression;
break;
case ':':
InsertText(upto, c, result);
result.push_back(cmGeneratorExpressionToken(
cmGeneratorExpressionToken::ColonSeparator, c, 1));
result.emplace_back(cmGeneratorExpressionToken::ColonSeparator, c, 1);
upto = c + 1;
break;
case ',':
InsertText(upto, c, result);
result.push_back(cmGeneratorExpressionToken(
cmGeneratorExpressionToken::CommaSeparator, c, 1));
result.emplace_back(cmGeneratorExpressionToken::CommaSeparator, c, 1);
upto = c + 1;
break;
default: