mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-03-12 04:20:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

Unity: refactor unity extension logic to single function

Browse Source
This commit is contained in:
Robert Maynard
2024-07-16 09:38:19 -04:00
parent ac4f6d513d
commit c99ff40b21
1 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
Source/cmLocalGenerator.cxx
View File

@@ -3154,6 +3154,23 @@ void cmLocalGenerator::WriteUnitySourceInclude(
unity_file << "\n"; unity_file << "\n";
} }
namespace {
std::string unity_file_extension(std::string const& lang)
{
std::string extension;
if (lang == "C") {
extension = "_c.c";
} else if (lang == "CXX") {
extension = "_cxx.cxx";
} else if (lang == "OBJC") {
extension = "_m.m";
} else if (lang == "OBJCXX") {
extension = "_mm.mm";
}
return extension;
}
}
std::vector<cmLocalGenerator::UnitySource> std::vector<cmLocalGenerator::UnitySource>
cmLocalGenerator::AddUnityFilesModeAuto( cmLocalGenerator::AddUnityFilesModeAuto(
cmGeneratorTarget* target, std::string const& lang, cmGeneratorTarget* target, std::string const& lang,
@@ -3172,17 +3189,8 @@ cmLocalGenerator::AddUnityFilesModeAuto(
chunk = std::min(itemsLeft, batchSize); chunk = std::min(itemsLeft, batchSize);
std::string extension; std::string filename =
if (lang == "C") { cmStrCat(filename_base, "unity_", batch, unity_file_extension(lang));
extension = "_c.c";
} else if (lang == "CXX") {
extension = "_cxx.cxx";
} else if (lang == "OBJC") {
extension = "_m.m";
} else if (lang == "OBJCXX") {
extension = "_mm.mm";
}
std::string filename = cmStrCat(filename_base, "unity_", batch, extension);
auto const begin = filtered_sources.begin() + batch * batchSize; auto const begin = filtered_sources.begin() + batch * batchSize;
auto const end = begin + chunk; auto const end = begin + chunk;
unity_files.emplace_back(this->WriteUnitySource( unity_files.emplace_back(this->WriteUnitySource(
@@ -3220,8 +3228,8 @@ cmLocalGenerator::AddUnityFilesModeGroup(
for (auto const& item : explicit_mapping) { for (auto const& item : explicit_mapping) {
auto const& name = item.first; auto const& name = item.first;
std::string filename = cmStrCat(filename_base, "unity_", name, std::string filename =
(lang == "C") ? "_c.c" : "_cxx.cxx"); cmStrCat(filename_base, "unity_", name, unity_file_extension(lang));
unity_files.emplace_back(this->WriteUnitySource( unity_files.emplace_back(this->WriteUnitySource(
target, configs, cmMakeRange(item.second), beforeInclude, afterInclude, target, configs, cmMakeRange(item.second), beforeInclude, afterInclude,
std::move(filename))); std::move(filename)));