From cc9290f9835f51631404351d684710ec2f0b0b5d Mon Sep 17 00:00:00 2001 From: Brad King Date: Fri, 17 Oct 2025 17:41:33 -0400 Subject: [PATCH] cmake --build: Remove unnecessary source and build directory tracking The save/restore from commit 427b6da9e5 (VS: Teach `cmake --build` to reconfigure if needed before building, 2016-09-16, v3.8.0-rc1~290^2) is unnecessary because `cmake::Build` does not rely on the source and build directory being initialized. --- Source/cmake.cxx | 6 ------ 1 file changed, 6 deletions(-) diff --git a/Source/cmake.cxx b/Source/cmake.cxx index b3a1f79efc..42bf55df9e 100644 --- a/Source/cmake.cxx +++ b/Source/cmake.cxx @@ -4020,8 +4020,6 @@ int cmake::Build(int jobs, std::string dir, std::vector targets, if (!cmakeCheckStampList(stampList)) { // Correctly initialize the home (=source) and home output (=binary) // directories, which is required for running the generation step. - std::string homeOrig = this->GetHomeDirectory(); - std::string homeOutputOrig = this->GetHomeOutputDirectory(); this->SetDirectoriesFromFile(cachePath); this->AddProjectCommands(); @@ -4041,10 +4039,6 @@ int cmake::Build(int jobs, std::string dir, std::vector targets, std::string message = cmStrCat("Build files have been written to: ", this->GetHomeOutputDirectory()); this->UpdateProgress(message, -1); - - // Restore the previously set directories to their original value. - this->SetHomeDirectory(homeOrig); - this->SetHomeOutputDirectory(homeOutputOrig); } } #endif