diff --git a/Source/MFCDialog/CMakeSetupDialog.cpp b/Source/MFCDialog/CMakeSetupDialog.cpp index 719696ebdf..e17a03d907 100644 --- a/Source/MFCDialog/CMakeSetupDialog.cpp +++ b/Source/MFCDialog/CMakeSetupDialog.cpp @@ -807,7 +807,7 @@ void CMakeSetupDialog::FillCacheGUIFromCacheManager() { cmCacheManager *cachem = this->m_CMakeInstance->GetCacheManager(); cmCacheManager::CacheIterator it = cachem->NewIterator(); - size_t size = m_CacheEntriesList.GetItems().size(); + // if there are already entries in the cache, then // put the new ones in the top, so they show up first bool reverseOrder = false; diff --git a/Source/MFCDialog/PathDialog.cpp b/Source/MFCDialog/PathDialog.cpp index c3972167bd..d7bd427983 100644 --- a/Source/MFCDialog/PathDialog.cpp +++ b/Source/MFCDialog/PathDialog.cpp @@ -205,7 +205,7 @@ int CPathDialog::DoModal() return iResult; } -BOOL CPathDialog::IsFileNameValid(LPCTSTR lpFileName) +BOOL CPathDialog::IsFileNameValid(LPCTSTR /* lpFileName */) { return TRUE; } @@ -232,7 +232,7 @@ const TCHAR c_szErrCreatePath[] = _T( int CPathDialog::MakeSurePathExists(LPCTSTR lpPath) { CString strMsg; - int iRet; + int iRet = -1; try { //validate path @@ -273,7 +273,6 @@ int CPathDialog::MakeSurePathExists(LPCTSTR lpPath) } AfxMessageBox(strMsg, MB_OK|MB_ICONEXCLAMATION); - } return iRet; diff --git a/Source/MFCDialog/PropertyList.cpp b/Source/MFCDialog/PropertyList.cpp index 8765fa81ba..e316451476 100644 --- a/Source/MFCDialog/PropertyList.cpp +++ b/Source/MFCDialog/PropertyList.cpp @@ -677,7 +677,7 @@ CPropertyItem* CPropertyList::GetItem(int index) return (CPropertyItem*)GetItemDataPtr(index); } -void CPropertyList::OnRButtonUp( UINT nFlags, CPoint point ) +void CPropertyList::OnRButtonUp( UINT /* nFlags */, CPoint point ) { CMenu menu; CRect rect; @@ -759,7 +759,6 @@ void CPropertyList::RemoveAll() int c = this->GetCount(); for(int i =0; i < c; ++i) { - CPropertyItem* pItem = (CPropertyItem*) GetItemDataPtr(0); this->DeleteString(0); } for(std::set::iterator ii = m_PropertyItems.begin();