mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-12-31 10:50:16 -06:00
Code Issues Packages Projects Releases Wiki Activity

APPLE: Check if compilers respect CMAKE_OSX_ARCHITECTURES

Browse Source 
Not all compilers that can be used on APPLE platforms will respect
the architecture(s) set in CMAKE_OSX_ARCHITECTURES and some will
not raise an error if they are unable to do this. For instance,
GCC will accept ignore additional architectures specified after the
first -arch XXX (with a non-fatal warning) and will even link the
simple test applications used in the ABI determination (and other
tests that don't require external libraries) if an architecture
is requested for which it doesn't have the required "multilib"
set-up.

Prevent unexpected build results or build failures that may occur
after a lengthy build process: verify that the binary used to obtain
the ABI information contains the requested architectures.

Fixes: #25952
This commit is contained in:
René Bertin
2024-05-04 19:59:27 +02:00
committed by Brad King
parent 598bc70474
commit db409e5e68
1 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
Modules/CMakeDetermineCompilerABI.cmake
View File

@@ -99,6 +99,41 @@ function(CMAKE_DETERMINE_COMPILER_ABI lang src)
# Load the resulting information strings.
if(CMAKE_${lang}_ABI_COMPILED)
message(CHECK_PASS "done")
if(CMAKE_HOST_APPLE AND CMAKE_SYSTEM_NAME STREQUAL "Darwin")
file(READ_MACHO "${BIN}" ARCHITECTURES archs CAPTURE_ERROR macho_error) # undocumented file() subcommand
if (NOT macho_error)
# sort and prune the list of found architectures
set(arch_list_sorted ${archs})
list(SORT arch_list_sorted)
list(REMOVE_DUPLICATES arch_list_sorted)
# sort and prune the list of requested architectures
set(requested_arch_list ${CMAKE_OSX_ARCHITECTURES})
list(SORT requested_arch_list)
list(REMOVE_DUPLICATES requested_arch_list)
message(CONFIGURE_LOG
"Effective list of requested architectures (possibly empty) : \"${requested_arch_list}\"\n"
"Effective list of architectures found in the ABI info binary: \"${arch_list_sorted}\"\n")
# If all generated architectures were known to READ_MACHO (i.e. libmacho):
# Compare requested and found:
# - if no architecture(s) were requested explicitly, just check if READ_MACHO returned
# an architecture for the ABI info binary.
# - otherwise, check if the requested and found lists are equal
if(arch_list_sorted MATCHES "unknown")
# Rare but not impossible: a host with a toolchain capable of generating binaries with
# architectures that the system libmacho is too old to know. Report the found archs as
# usual, warn about the unknowns and skip the comparison with CMAKE_OSX_ARCHITECTURES.
message(WARNING "The ${lang} compiler generates universal binaries with at least 1 architecture not known to the host")
elseif(requested_arch_list AND arch_list_sorted
AND NOT "${requested_arch_list}" STREQUAL "${arch_list_sorted}")
# inform the user of the mismatch but show the raw input and output lists
message(FATAL_ERROR
"The ${lang} compiler targets architectures:\n"
" \"${archs}\"\n"
"but CMAKE_OSX_ARCHITECTURES is\n"
" \"${CMAKE_OSX_ARCHITECTURES}\"\n")
endif()
endif()
endif()
cmake_policy(PUSH)
cmake_policy(SET CMP0159 NEW) # file(STRINGS) with REGEX updates CMAKE_MATCH_<n>
file(STRINGS "${BIN}" ABI_STRINGS LIMIT_COUNT 32 REGEX "INFO:[A-Za-z0-9_]+\\[[^]]*\\]")