mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-03 04:10:05 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmake-gui: Fix "Open Project" for VS IDE with space in path

Browse Source 
Do not encode the path for a shell until after we check that it exists.

Fixes: #18501
This commit is contained in:
Brad King
2018-10-25 07:19:02 -04:00
parent fd02538974
commit e178bd46cb
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Source/cmGlobalVisualStudioGenerator.cxx
View File

@@ -878,12 +878,13 @@ bool cmGlobalVisualStudioGenerator::Open(const std::string& bindir,
const std::string& projectName, const std::string& projectName,
bool dryRun) bool dryRun)
{ {
std::string buildDir = cmSystemTools::ConvertToOutputPath(bindir); std::string sln = bindir + "/" + projectName + ".sln";
std::string sln = buildDir + "\\" + projectName + ".sln";
if (dryRun) { if (dryRun) {
return cmSystemTools::FileExists(sln, true); return cmSystemTools::FileExists(sln, true);
} }
sln = cmSystemTools::ConvertToOutputPath(sln);
return std::async(std::launch::async, OpenSolution, sln).get(); return std::async(std::launch::async, OpenSolution, sln).get();
} }