mirror of
https://github.com/Kitware/CMake.git
synced 2026-05-07 22:59:56 -05:00
Swift: Omit output-file-map when used as a linker
Swift is used as the linker for non-swift files because it needs to pull files like swiftrt.o in when swift symbols are present to ensure that the swift runtime is linked. The swift driver uses clang as the underlying linker, which pulls in crtbegin.o and friends when appropriate, so using Swift as a linker for C/C++ libraries is fine. The output-file-map was getting passed to all Swift invocations, regardless of whether or not we generated one. This patch changes it so that we only include the output-file-map in the Swift compiler invocation if we have actually generated the file.
This commit is contained in:
@@ -372,7 +372,6 @@ void cmNinjaNormalTargetGenerator::WriteLinkRule(bool useResponseFile,
|
||||
vars.SwiftLibraryName = "$SWIFT_LIBRARY_NAME";
|
||||
vars.SwiftModule = "$SWIFT_MODULE";
|
||||
vars.SwiftModuleName = "$SWIFT_MODULE_NAME";
|
||||
vars.SwiftOutputFileMap = "$SWIFT_OUTPUT_FILE_MAP";
|
||||
vars.SwiftSources = "$SWIFT_SOURCES";
|
||||
|
||||
vars.Defines = "$DEFINES";
|
||||
@@ -1072,12 +1071,6 @@ void cmNinjaNormalTargetGenerator::WriteLinkStatement(
|
||||
cmOutputConverter::SHELL);
|
||||
}(vars["SWIFT_MODULE_NAME"]);
|
||||
|
||||
const std::string map = cmStrCat(gt->GetSupportDirectory(), '/', config,
|
||||
'/', "output-file-map.json");
|
||||
vars["SWIFT_OUTPUT_FILE_MAP"] =
|
||||
this->GetLocalGenerator()->ConvertToOutputFormat(
|
||||
this->ConvertToNinjaPath(map), cmOutputConverter::SHELL);
|
||||
|
||||
vars["SWIFT_SOURCES"] = [this, config]() -> std::string {
|
||||
std::vector<cmSourceFile const*> sources;
|
||||
std::stringstream oss;
|
||||
@@ -1101,6 +1094,7 @@ void cmNinjaNormalTargetGenerator::WriteLinkStatement(
|
||||
vars["DEFINES"] = this->GetDefines("Swift", config);
|
||||
vars["FLAGS"] = this->GetFlags("Swift", config);
|
||||
vars["INCLUDES"] = this->GetIncludes("Swift", config);
|
||||
this->GenerateSwiftOutputFileMap(config, vars["FLAGS"]);
|
||||
}
|
||||
|
||||
// Compute specific libraries to link with.
|
||||
|
||||
Reference in New Issue
Block a user