Graphviz: add missing support for circular dependencies

This support was actually added by removing a superfluous check that was
too eager in cmLinkItemGraphVisitor.cxx.

Extended the existing Graphviz tests to include this particular case,
and re-generated the expected output files.

Fixes: #20720
This commit is contained in:
Corentin Plouet
2020-06-21 23:54:59 +10:00
parent 71f6c7badf
commit ee5eb2eab4
18 changed files with 286 additions and 234 deletions

View File

@@ -24,10 +24,6 @@ void cmLinkItemGraphVisitor::VisitItem(cmLinkItem const& item)
void cmLinkItemGraphVisitor::VisitLinks(cmLinkItem const& item,
cmLinkItem const& rootItem)
{
if (this->LinkVisited(item, rootItem)) {
return;
}
if (item.Target == nullptr) {
return;
}