mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-03-10 19:39:52 -05:00
Code Issues Packages Projects Releases Wiki Activity

ExternalProject: Quote each git --config option to handle spaces

Browse Source 
Fixes: #20354
This commit is contained in:
Craig Scott
2020-02-15 13:21:32 +11:00
parent 40d1d29cfa
commit ef3194a6f8
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Modules/ExternalProject.cmake
View File

@@ -1096,7 +1096,7 @@ function(_ep_write_gitclone_script script_filename source_dir git_EXECUTABLE git
list(APPEND git_clone_options --progress) list(APPEND git_clone_options --progress)
endif() endif()
foreach(config IN LISTS git_config) foreach(config IN LISTS git_config)
list(APPEND git_clone_options --config ${config}) list(APPEND git_clone_options --config \"${config}\")
endforeach() endforeach()
if(NOT ${git_remote_name} STREQUAL "origin") if(NOT ${git_remote_name} STREQUAL "origin")
list(APPEND git_clone_options --origin \"${git_remote_name}\") list(APPEND git_clone_options --origin \"${git_remote_name}\")

4
Tests/ExternalProject/CMakeLists.txt
View File

@@ -380,7 +380,9 @@ if(do_git_tests)
set(proj TutorialStep1-GIT-config) set(proj TutorialStep1-GIT-config)
ExternalProject_Add(${proj} ExternalProject_Add(${proj}
GIT_REPOSITORY "${local_git_repo}" GIT_REPOSITORY "${local_git_repo}"
GIT_CONFIG core.eol=lf core.autocrlf=input GIT_CONFIG core.eol=lf
core.autocrlf=input
"http.extraheader=AUTHORIZATION: bearer --unsupportedOption"
CMAKE_GENERATOR "${CMAKE_GENERATOR}" CMAKE_GENERATOR "${CMAKE_GENERATOR}"
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX:PATH=<INSTALL_DIR> CMAKE_ARGS -DCMAKE_INSTALL_PREFIX:PATH=<INSTALL_DIR>
INSTALL_COMMAND "" INSTALL_COMMAND ""