mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-11 16:32:14 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmGeneratorTarget: Skip computing link implementation for custom targets

Browse Source 
Targets created by `add_custom_target` cannot be used with
`target_link_libraries` and so have no link implementation.
This commit is contained in:
Brad King
2020-07-14 15:54:01 -04:00
parent 45158b2afe
commit ef796cc743
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Source/cmGeneratorTarget.cxx
View File

@@ -2467,6 +2467,12 @@ private:
cmGeneratorTarget::LinkClosure const* cmGeneratorTarget::GetLinkClosure(
const std::string& config) const
{
// There is no link implementation for targets that cannot compile sources.
if (!this->CanCompileSources()) {
static LinkClosure const empty = { {}, {} };
return ∅
}
std::string key(cmSystemTools::UpperCase(config));
auto i = this->LinkClosureMap.find(key);
if (i == this->LinkClosureMap.end()) {
@@ -2783,6 +2789,12 @@ const std::vector<const cmGeneratorTarget*>&
cmGeneratorTarget::GetLinkImplementationClosure(
const std::string& config) const
{
// There is no link implementation for targets that cannot compile sources.
if (!this->CanCompileSources()) {
static std::vector<const cmGeneratorTarget*> const empty;
return empty;
}
LinkImplClosure& tgts = this->LinkImplClosureMap[config];
if (!tgts.Done) {
tgts.Done = true;
@@ -6856,8 +6868,8 @@ const cmLinkImplementation* cmGeneratorTarget::GetLinkImplementation(
const cmLinkImplementation* cmGeneratorTarget::GetLinkImplementation(
const std::string& config, bool secondPass) const
{
// There is no link implementation for imported targets.
if (this->IsImported()) {
// There is no link implementation for targets that cannot compile sources.
if (!this->CanCompileSources()) {
return nullptr;
}
@@ -7120,8 +7132,8 @@ cmLinkImplementationLibraries const*
cmGeneratorTarget::GetLinkImplementationLibrariesInternal(
const std::string& config, cmGeneratorTarget const* head) const
{
// There is no link implementation for imported targets.
if (this->IsImported()) {
// There is no link implementation for targets that cannot compile sources.
if (!this->CanCompileSources()) {
return nullptr;
}