mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-05-03 04:40:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

Prefer front/back/data over dereferencing begin/rbegin iter

Browse Source 
Changed for sequenced containers: vector, list, string and array
This commit is contained in:
Artur Ryt
2019-02-04 22:56:42 +01:00
committed by Brad King
parent 062cfd991f
commit f3534386b5
22 changed files with 64 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmGeneratorExpressionParser.cxx
+3 -3
View File
@@ -47,11 +47,11 @@ static void extendResult(
if (!result.empty() &&
(*(result.end() - 1))->GetType() ==
cmGeneratorExpressionEvaluator::Text &&
(*contents.begin())->GetType() == cmGeneratorExpressionEvaluator::Text) {
contents.front()->GetType() == cmGeneratorExpressionEvaluator::Text) {
TextContent* textContent = static_cast<TextContent*>(*(result.end() - 1));
textContent->Extend(
static_cast<TextContent*>(*contents.begin())->GetLength());
delete *contents.begin();
static_cast<TextContent*>(contents.front())->GetLength());
delete contents.front();
result.insert(result.end(), contents.begin() + 1, contents.end());
} else {
result.insert(result.end(), contents.begin(), contents.end());