mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-05-03 21:00:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: address bugprone-sizeof-expression lint

Browse Source
This commit is contained in:
Ben Boeckel
2020-04-08 11:56:47 -04:00
parent 609c3b7cdc
commit f413727d27
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmGlobalGenerator.cxx
+4 -2
View File
@@ -2253,10 +2253,12 @@ std::string cmGlobalGenerator::IndexGeneratorTargetUniquely(
// Use a ":" prefix to avoid conflict with project-defined targets. // Use a ":" prefix to avoid conflict with project-defined targets.
// We must satisfy cmGeneratorExpression::IsValidTargetName so use no // We must satisfy cmGeneratorExpression::IsValidTargetName so use no
// other special characters. // other special characters.
char buf[1 + sizeof(gt) * 2]; constexpr size_t sizeof_ptr =
sizeof(gt); // NOLINT(bugprone-sizeof-expression)
char buf[1 + sizeof_ptr * 2];
char* b = buf; char* b = buf;
*b++ = ':'; *b++ = ':';
for (size_t i = 0; i < sizeof(gt); ++i) { for (size_t i = 0; i < sizeof_ptr; ++i) {
unsigned char const c = reinterpret_cast<unsigned char const*>(&gt)[i]; unsigned char const c = reinterpret_cast<unsigned char const*>(&gt)[i];
*b++ = hexDigits[(c & 0xf0) >> 4]; *b++ = hexDigits[(c & 0xf0) >> 4];
*b++ = hexDigits[(c & 0x0f)]; *b++ = hexDigits[(c & 0x0f)];