mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-08 14:50:10 -06:00
Code Issues Packages Projects Releases Wiki Activity

file(CREATE_LINK): Refactor error handling for removal of destination

Browse Source 
Avoid relying on global state.
This commit is contained in:
Brad King
2025-10-21 10:44:43 -04:00
committed by hanna.rusakovich
parent 0448f646a8
commit f719a36bc0
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
Source/cmFileCommand.cxx
View File

@@ -3233,18 +3233,20 @@ bool HandleCreateLinkCommand(std::vector<std::string> const& args,
}
// Check if the new file already exists and remove it.
if (cmSystemTools::PathExists(newFileName) &&
!cmSystemTools::RemoveFile(newFileName)) {
auto err = cmStrCat("Failed to create link '", newFileName,
"' because existing path cannot be removed: ",
cmSystemTools::GetLastSystemError(), '\n');
if (cmSystemTools::PathExists(newFileName)) {
cmsys::Status rmStatus = cmSystemTools::RemoveFile(newFileName);
if (!rmStatus) {
auto err = cmStrCat("Failed to create link '", newFileName,
"' because existing path cannot be removed: ",
rmStatus.GetString(), '\n');
if (!arguments.Result.empty()) {
status.GetMakefile().AddDefinition(arguments.Result, err);
return true;
if (!arguments.Result.empty()) {
status.GetMakefile().AddDefinition(arguments.Result, err);
return true;
}
status.SetError(err);
return false;
}
status.SetError(err);
return false;
}
// Whether the operation completed successfully.