Commit Graph

25401 Commits

Author SHA1 Message Date
Brad King
772edffbf0 Merge topic 'readability-static-accessed-through-instance'
3e60580784 clang-tidy: Fix readability-static-accessed-through-instance

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2647
2018-11-28 09:07:45 -05:00
Brad King
58ebbf14c2 Merge topic 'clang-tidy-macos'
cb6229b8b8 clang-tidy: fix warnings in macOS-only code

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2670
2018-11-28 09:07:07 -05:00
Brad King
b134e89430 Merge topic 'explicit-operator-bool'
a2648dda97 Mark operator bool explicit

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2649
2018-11-28 09:06:00 -05:00
Brad King
5daf7d92f8 Merge topic 'file-size'
12b471e828 file: add SIZE option

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2639
2018-11-28 09:05:16 -05:00
Brad King
6bfcd4db3b Merge topic 'autogen_uic_empty_fix_3_13'
b1b5004c1a Autogen: Fix empty uic executable string

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2667
2018-11-28 06:42:58 -05:00
Kitware Robot
049ca05da9 CMake Nightly Date Stamp 2018-11-28 00:01:05 -05:00
Brad King
cb6229b8b8 clang-tidy: fix warnings in macOS-only code 2018-11-27 13:20:34 -05:00
Brad King
bae71966fb Merge topic 'ctest-updates'
d9195ab081 Tests: Teach run_ctest to handle removal of CTestConfig.cmake
1ca53f5ef1 Remove unnecessary CTEST_PROJECT_NAME variables
15ac4aae0e Remove warning when no CTestConfig.cmake file exists
3125c47d27 ctest_build: Do not require unnecessary [CTEST_]PROJECT_NAME value
36bbd07a76 CDashUpload: Use the query part of the submit url as field
e1dfe8cee6 CTest: Don't require 'submit.php?' in submit location

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2640
2018-11-27 08:48:49 -05:00
Brad King
43deb8e004 Merge topic 'vs2015-no-sdk'
f54d28a838 VS: Avoid crash with VS 2015 when all SDKs are higher than 10.0.14393.0

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2656
2018-11-27 08:45:00 -05:00
Sebastian Holtermann
b1b5004c1a Autogen: Fix empty uic executable string
In CMake 3.13.0 when a target has ``AUTOUIC`` enabled but doesn't
link against Qt5Widgets, the uic executable string is empty and
an error string "The uic executable \"\" does not exist" is generated.
In CMake 3.12 ``AUTOUIC`` was silently disabled instead.
This patch fixes the regression and restores the behavior of CMake 3.12.

Fixes: #18630
2018-11-27 08:21:40 -05:00
Wouter Klouwen
12b471e828 file: add SIZE option
This commit adds the SIZE option to file(). It returns the file size of
the given path if it exists and produces an error if not.
2018-11-27 08:50:36 +00:00
Kitware Robot
cee843475d CMake Nightly Date Stamp 2018-11-27 00:01:04 -05:00
Harry Mallon
f54d28a838 VS: Avoid crash with VS 2015 when all SDKs are higher than 10.0.14393.0
Move the filter added by commit v3.13.0-rc1~72^2~2 (VS: Do not select a
Windows SDK too high for current VS version, 2017-08-07, committed
2018-09-17) to before our check that the remaining list is empty.
Otherwise we crash when dereferencing the first entry of an empty
vector.

Also add a comment explaining where 10.0.14393.0 came from.

Fixes: #18633
2018-11-26 13:42:50 -05:00
Brad King
5bc33226b2 Merge topic 'windows-taskbar-progress'
9175a378f5 QtDialog: Add windows taskbar progress

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2628
2018-11-26 08:00:36 -05:00
Brad King
ada1041754 Merge topic 'clang-tidy-bugprone'
ce2570b207 clang-tidy: Enable checks from bugprone set

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2642
2018-11-26 08:00:01 -05:00
Brad King
af2960e0fd Merge topic 'cxx-checks-tolerate-sprintf-warning'
2ca89b5a69 C++ feature checks: Filter out libstdc++ sprintf warnings

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2643
2018-11-26 07:50:51 -05:00
Kitware Robot
6786345210 CMake Nightly Date Stamp 2018-11-26 00:01:04 -05:00
Kitware Robot
37317ece8a CMake Nightly Date Stamp 2018-11-25 00:01:03 -05:00
Kitware Robot
a44191abc4 CMake Nightly Date Stamp 2018-11-24 00:01:03 -05:00
Kitware Robot
0d6c98d895 CMake Nightly Date Stamp 2018-11-23 00:01:03 -05:00
Kitware Robot
f32c0a2400 CMake Nightly Date Stamp 2018-11-22 00:01:04 -05:00
Regina Pfeifer
3e60580784 clang-tidy: Fix readability-static-accessed-through-instance
Enable the check in .clang-tidy and fix all warnings.
2018-11-22 00:11:37 +01:00
Regina Pfeifer
ce2570b207 clang-tidy: Enable checks from bugprone set 2018-11-21 07:47:40 -05:00
Brad King
4e0c75b78f Merge topic 'clang-tidy'
5731ec30f0 clang-tidy: fix warnings from version 7

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2636
2018-11-21 07:42:32 -05:00
Brad King
a586b60129 Merge topic 'fortran-submodule-case'
ead16adfc8 Fortran: Fix module dependency scanning with upper-case SUBMODULE

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2644
2018-11-21 07:34:53 -05:00
Kitware Robot
3804122ab2 CMake Nightly Date Stamp 2018-11-21 00:01:04 -05:00
Regina Pfeifer
15ac4aae0e Remove warning when no CTestConfig.cmake file exists
Some CTestConfig.cmake files used to set CTEST_PROJECT_NAME only.
Since this variable is no longer used, it is more likely that the
whole file is no longer provided by projects.
2018-11-20 21:23:59 +01:00
Regina Pfeifer
3125c47d27 ctest_build: Do not require unnecessary [CTEST_]PROJECT_NAME value
Since commit v3.0.0-rc1~260^2~32 (ctest_build: Use "cmake --build"
to launch the native build tool, 2013-11-14) we no longer need to
use the project name in `ctest_build()`.

Fixes: #18612
2018-11-20 21:23:59 +01:00
Regina Pfeifer
36bbd07a76 CDashUpload: Use the query part of the submit url as field 2018-11-20 21:23:59 +01:00
Regina Pfeifer
e1dfe8cee6 CTest: Don't require 'submit.php?' in submit location
Fixes: #18611
2018-11-20 21:23:59 +01:00
Brad King
ead16adfc8 Fortran: Fix module dependency scanning with upper-case SUBMODULE
The lexical token expression added by commit v3.7.0-rc1~73^2~1 (Fortran:
Add support for submodule syntax in dependency scanning, 2016-09-05)
has a typo and does not match upper-case `B` in `SUBMODULE`.  Fix it.

Fixes: #18595
2018-11-20 14:16:26 -05:00
Brad King
2ca89b5a69 C++ feature checks: Filter out libstdc++ sprintf warnings
On OpenBSD linking to `libstdc++` with GCC 6.4 always warns:

    warning: sprintf() is often misused, please use snprintf()

These do not affect the availability of C++ features we're checking,
so filter them out.

Fixes: #18602
2018-11-20 12:50:45 -05:00
Julien Jomier
9175a378f5 QtDialog: Add windows taskbar progress 2018-11-20 17:16:08 +01:00
Regina Pfeifer
5731ec30f0 clang-tidy: fix warnings from version 7
Fix some warnings that are new since clang-tidy version 4, and update
`.clang-tidy` to suppress the rest.
2018-11-20 10:36:08 -05:00
Brad King
05a2ca7f87 CMake 3.13.0 2018-11-20 09:31:28 -05:00
Brad King
aed259ac41 Merge topic 'genex-in_list-empty-args'
b5f8113ca7 Genex: Add policy to handle empty list items in $<IN_LIST:...>

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2569
2018-11-20 09:29:44 -05:00
Kitware Robot
d851a8b457 CMake Nightly Date Stamp 2018-11-20 00:01:05 -05:00
Regina Pfeifer
a2648dda97 Mark operator bool explicit 2018-11-19 23:35:09 +01:00
Kyle Edwards
b5f8113ca7 Genex: Add policy to handle empty list items in $<IN_LIST:...>
The old behavior of $<IN_LIST:...> is inconsistent with that of
if(IN_LIST), in that it does not find an empty search item even if
the list contains empty items. This change adds a new policy to
correctly handle empty items and make the behavior more consistent
with if(IN_LIST).

Fixes: #18556
2018-11-19 17:02:06 -05:00
Brad King
e593161bd5 Merge branch 'backport-configure_file-canonical-deps' into release-3.13
Merge-request: !2635
2018-11-19 10:14:26 -05:00
Frank Benkstein
57701227d6 configure_file: canonicalize input and output path in dependencies
Represent the input file path internally in canonical form.  Otherwise
multiple `configure_file` calls that share the same input file but specify
it relative to different directories (e.g. via `../`) result in multiple
copies of the dependency on the rule to re-run CMake.  This causes the
Ninja generator to emit duplicate phony build statements for these
dependencies, which generates an error with `-w dupbuild=err`, which
will be default in Ninja 1.9.

Also canonicalize the output path for consistency.

Add a test case.

Fixes: #18584
2018-11-19 10:11:12 -05:00
Brad King
d9d8816f39 Merge topic 'pie-link-options'
b10f7ac534 CMP0083: fix warning message on try_compile

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2619
2018-11-19 09:57:13 -05:00
Brad King
95a735116f Merge topic 'ctest-stdin'
86e8315482 CTest: Restore inheritance of stdin by test processes
bdec3bd896 Tests: Teach RunCMake infrastructure to optionally provide stdin

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2618
2018-11-19 09:52:07 -05:00
Marc Chevrier
b10f7ac534 CMP0083: fix warning message on try_compile
Fixes: #18593
2018-11-19 10:56:02 +01:00
Kitware Robot
61e3ceda21 CMake Nightly Date Stamp 2018-11-19 00:01:04 -05:00
Kitware Robot
6f5cdc0c83 CMake Nightly Date Stamp 2018-11-18 00:01:11 -05:00
Kitware Robot
be9ad8279a CMake Nightly Date Stamp 2018-11-17 00:01:03 -05:00
Kitware Robot
7aa41095fd CMake Nightly Date Stamp 2018-11-16 00:01:04 -05:00
Brad King
20aab1a4e7 Merge topic 'configure_file-canonical-deps'
6199637e95 configure_file: canonicalize input and output path in dependencies

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2586
2018-11-15 10:40:33 -05:00
Brad King
59fc717c25 Merge topic 'deprecate-findqt'
0f5c1b404b find_package(): Add policy to remove the FindQt module

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: noo mook <noomook2519@gmail.com>
Merge-request: !2554
2018-11-15 10:39:55 -05:00