Brad King
e15314420c
Merge topic 'iwyu-memory'
...
71fbebd1dc IWYU: Fix handling of <memory> standard header
Acked-by: Kitware Robot <kwrobot@kitware.com >
Acked-by: Marc Chevrier <marc.chevrier@gmail.com >
Merge-request: !3536
2019-07-11 08:52:36 -04:00
Brad King
71fbebd1dc
IWYU: Fix handling of <memory> standard header
...
An old workaround for `std::allocator_traits<>::value_type` lints from
IWYU on `std::vector<>` usage breaks IWYU's handling of `<memory>`.
Convert the workaround to use the same approach we already use for a
workaround of `std::__decay_and_strip<>::::__type` lints. Then update
the `<memory>` inclusions to follow the now-correct IWYU lints.
2019-07-10 11:48:56 -04:00
Stephen Manz
adcbdb143c
CTest: Clean up stdout and logfile output for Pass/Fail regex
...
For pass regex, display only the element that was found, rather
than all elements
Rename loop variable for fail regex, from pass to fail
For consistency, add space in output for pass
Add tests that find and don't find PASS_REGULAR_EXPRESSION, and a test
that finds FAIL_REGULAR_EXPRESSION, whose LastTest.log files are checked
using *-check.cmake.
2019-07-09 09:01:04 -07:00
Sebastian Holtermann
006229278b
Use cmAppend to append ranges to std::vector instances
2019-05-23 16:19:49 +02:00
Vitaly Stakhovsky
e884b1b693
cmSystemTools::Error(): remove const char* overload
2019-05-22 10:51:06 -04:00
Zack Galbreath
2a34d0ac36
ctest: Add new variable CTEST_UPDATE_VERSION_OVERRIDE
...
Set this in a CTest script to explicitly define what the current revision
will be reported as in Update.xml.
2019-05-07 10:45:47 -04:00
Kyle Edwards
c0e6b22d0a
Refactor: Move/rename cmProcessGetPipes() to cmGetPipes()
2019-04-25 12:03:08 -04:00
Zack Galbreath
d8af0700a3
ctest: consistently format generator name
...
Notes.xml and Upload.xml were missing a hyphen that the rest of
our XML files included.
ctest3.14.0-rc1 vs. ctest-3.14.0-rc1
2019-04-23 15:02:14 -04:00
Zack Galbreath
95db11fdb1
ctest: Include ChangeId in Update.xml
2019-04-23 14:56:46 -04:00
Brad King
81cc3de28e
ctest: drop incremental progress-only messages from build-and-test output
...
The cmake progress callback is called with non-negative progress values
to provide incremental updates on "Configuring" and "Generating" steps.
These are useful in interactive views but are just noise in test output.
2019-04-12 12:07:31 -04:00
Artur Ryt
30bb14c657
Modernize: Enable modernize-raw-string-literal in clang-tidy
2019-04-02 19:59:54 +02:00
Brad King
fa2dbbbdde
Merge topic 'utilize-substr'
...
2d66567dca Modernize: Prefer .substr in place of .c_str() + int
Acked-by: Kitware Robot <kwrobot@kitware.com >
Acked-by: Sebastian Holtermann <sebholt@xwmw.org >
Merge-request: !3169
2019-04-01 10:46:24 -04:00
Sebastian Holtermann
735c6f39d9
Fix invalid ///! doxygen comment line starts
...
In various places `///!` was used to start a comment line. This is not valid
Doygen syntax. This patch replaces `///!` comment starts with `//!`.
2019-03-31 11:27:12 +02:00
Artur Ryt
2d66567dca
Modernize: Prefer .substr in place of .c_str() + int
...
A lot of temporary/local strings were created out of C-strings
substr can utilize current string size, so in theory be a little
more efficient.
2019-03-30 16:15:05 +01:00
Brad King
a60f1c4faf
Merge topic 'jacoco_parser_crash'
...
1d16eae868 ctest_coverage: fix out-of-bounds index in Jacoco parser
Acked-by: Kitware Robot <kwrobot@kitware.com >
Merge-request: !3147
2019-03-27 14:11:57 -04:00
Sylvain Joubert
1d16eae868
ctest_coverage: fix out-of-bounds index in Jacoco parser
...
When the current source file is not found the FilePath variable was left
with the previous path content. In case the previous file had less lines
than the current one and there are 'line' entries for the current one
with higher number we ended up in a buffer overflow while indexing the
previous file entry with a line number higher. By clearing the
FilePath, the empty() guard triggers correctly on an empty path and it
avoid modifying the wrong data.
2019-03-26 11:50:30 -04:00
Zack Galbreath
ba7e44eb7a
ctest_submit: Add option BUILD_ID
...
Fixes : #18968
2019-03-22 09:37:08 -04:00
Brad King
732b7b9dd0
Merge topic 'ctest-devirtualize-handlers'
...
5a72dbd40c cmCTest: Remove dead code
a5eeb0310d cmCTest: Cleanup typedefs
71a3391b5f cmCTest: Use default member initialization
b172a81d55 cmCTest: Use concrete accessor functions for TestingHandlers
46090c2337 cmCTest: Store TestingHandlers by value
da5ee509b2 cmCTest: Move all data members to private implementation struct
670d27da64 cmCTest: Remove friend declarations
9406844616 cmCTest: De-inline all member functions
Acked-by: Kitware Robot <kwrobot@kitware.com >
Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de >
Merge-request: !3114
2019-03-21 09:44:13 -04:00
Regina Pfeifer
a5eeb0310d
cmCTest: Cleanup typedefs
2019-03-20 11:41:29 -04:00
Regina Pfeifer
b172a81d55
cmCTest: Use concrete accessor functions for TestingHandlers
2019-03-20 11:39:14 -04:00
Regina Pfeifer
670d27da64
cmCTest: Remove friend declarations
2019-03-18 22:25:50 +01:00
Sebastian Holtermann
5536cec46e
Rename cmFileTimeCache::FileTimeCompare to cmFileTimeCache::Compare
2019-03-18 15:09:11 +01:00
Sebastian Holtermann
216416219a
Rename cmFileTimeComparison to cmFileTimeCache
...
The name `cmFileTimeCache` reflects the functionality of the class more
appropriately.
2019-03-18 15:09:11 +01:00
Kyle Edwards
2992ba2d02
Merge topic 'feature/cleanup-ctest'
...
1166aa5ce7 ctest: refactor some code
Acked-by: Kitware Robot <kwrobot@kitware.com >
Merge-request: !3064
2019-03-07 09:46:03 -05:00
Gregor Jasny
1166aa5ce7
ctest: refactor some code
2019-03-05 19:20:29 +01:00
Bartosz Kosiorek
324d18bb34
cmake: Teach --build mode to support multiple targets
...
Fixes : #16136
2019-03-05 08:55:28 -05:00
Brad King
a4d99e4dec
Merge topic 'cmrange-improvements'
...
b8031308f3 cmRange: Add unit tests
a8d51ef8b7 cmRange: Add functions filter and transform
da4773e8b8 cmRange: Add functions all_of, any_of, none_of
17a367e77f cmRange: Stylistic cleanup
9eb0e73f46 cmRange: Move to dedicated header file
Acked-by: Kitware Robot <kwrobot@kitware.com >
Acked-by: Artur Ryt <artur.ryt@gmail.com >
Merge-request: !2972
2019-02-25 08:03:01 -05:00
Brad King
94970cd042
Merge topic 'error-consolidate'
...
9dd255548d cmSystemTools::Error: consolidate parameters into single std::string
Acked-by: Kitware Robot <kwrobot@kitware.com >
Merge-request: !2995
2019-02-25 08:02:07 -05:00
Regina Pfeifer
9eb0e73f46
cmRange: Move to dedicated header file
2019-02-21 08:24:25 -05:00
Vitaly Stakhovsky
4e315e9449
cmSystemTools: More functions accept std::string params
2019-02-20 14:53:39 -05:00
Vitaly Stakhovsky
9dd255548d
cmSystemTools::Error: consolidate parameters into single std::string
2019-02-20 11:18:11 -05:00
Albert Astals Cid
ae5e97a005
Delete some default constructors and assignment operators
...
They are unused, but if someone used them they would lead to
problems since they would copy the internal raw pointers
and the destructor would cause double delete
2019-02-15 07:25:47 -05:00
Brad King
8914d4317a
Merge topic 'systools-stdstring2'
...
080a79ca4a cmSystemTools: More methods accept `std::string` params
Acked-by: Kitware Robot <kwrobot@kitware.com >
Merge-request: !2952
2019-02-13 10:17:08 -05:00
Brad King
20afd497c9
Merge topic 'progress-stdstring'
...
950c099d83 cmake: Progress functions use `std::string` param
Acked-by: Kitware Robot <kwrobot@kitware.com >
Merge-request: !2948
2019-02-12 08:30:13 -05:00
Brad King
c0ba467d2d
Merge topic 'cmCTestRunTest-compress'
...
948c55857e cmCTestRunTest: Remove duplicated compression logic
Acked-by: Kitware Robot <kwrobot@kitware.com >
Merge-request: !2946
2019-02-12 08:28:24 -05:00
Vitaly Stakhovsky
080a79ca4a
cmSystemTools: More methods accept std::string params
2019-02-11 18:11:59 -05:00
Vitaly Stakhovsky
950c099d83
cmake: Progress functions use std::string param
2019-02-11 10:32:43 -05:00
Brad King
8a1d25afdf
Merge topic 'ctest-exit-code-int64'
...
440b08e4f0 CTest: Represent process exit codes as 64-bit signed integer
Acked-by: Kitware Robot <kwrobot@kitware.com >
Merge-request: !2944
2019-02-11 08:08:56 -05:00
Brad King
4b37b4f1bb
Merge topic 'modernize-for-loops'
...
01b2d6ab74 Modernize: Use ranged for-loops when possible
15bdbec017 cmAlgorithms: Make cmRange advance/retreat safe for rvalues
Acked-by: Kitware Robot <kwrobot@kitware.com >
Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de >
Merge-request: !2901
2019-02-11 08:08:22 -05:00
Regina Pfeifer
948c55857e
cmCTestRunTest: Remove duplicated compression logic
2019-02-10 15:47:15 +01:00
Zsolt Parragi
440b08e4f0
CTest: Represent process exit codes as 64-bit signed integer
...
Exit code constants on Windows, such as `STATUS_NO_MEMORY` do not fit in
a 32-bit signed integer type. They do fit in an unsigned 32-bit type,
but for compatibility with UNIX semantics we treat exit codes as signed.
Use a 64-bit signed integer to handle both.
2019-02-08 14:49:20 -05:00
Brad King
89ca5d7fdc
Merge topic 'message-stdstring'
...
82edd98300 cmSystemTools: MessageCallback and Message() accept std::string argument
Acked-by: Kitware Robot <kwrobot@kitware.com >
Merge-request: !2929
2019-02-08 08:49:35 -05:00
Brad King
9783825de5
Merge topic 'runsinglecommand'
...
65baaa0e37 cmSystemTools::RunSingleCommand: Accept std::string argument
Acked-by: Kitware Robot <kwrobot@kitware.com >
Merge-request: !2927
2019-02-08 08:47:56 -05:00
Artur Ryt
01b2d6ab74
Modernize: Use ranged for-loops when possible
...
Replaced most manual `const_iterator`-based loops and some
reverse-iterator loops with range loops.
Fixes : #18858
2019-02-07 22:39:05 +01:00
Vitaly Stakhovsky
82edd98300
cmSystemTools: MessageCallback and Message() accept std::string argument
2019-02-07 13:41:27 -05:00
Vitaly Stakhovsky
65baaa0e37
cmSystemTools::RunSingleCommand: Accept std::string argument
2019-02-06 11:02:10 -05:00
Artur Ryt
f3534386b5
Prefer front/back/data over dereferencing begin/rbegin iter
...
Changed for sequenced containers: vector, list, string and array
2019-02-06 10:43:16 -05:00
Regina Pfeifer
1180fc8780
OutputCallback: Accept std::string argument
2019-01-30 18:33:58 +01:00
Brad King
c30f9b1cde
Merge topic 'functional-callbacks'
...
8c92db829b MessageCallback: Remove unused bool& argument
bcee24aecc Use `std::function` for callbacks
Acked-by: Kitware Robot <kwrobot@kitware.com >
Acked-by: vvs31415 <vstakhovsky@fastmail.com >
Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de >
Merge-request: !2872
2019-01-30 08:10:27 -05:00
Brad King
d75fec5a88
Merge topic 'tidy-use-equals-default'
...
094f01d0f0 cleanup: Prefer compiler provided special member functions
55671b41d2 clang-tidy: Use `= default`
Acked-by: Kitware Robot <kwrobot@kitware.com >
Acked-by: Brad King <brad.king@kitware.com >
Merge-request: !2841
2019-01-29 14:07:24 -05:00