Commit Graph

67046 Commits

Author SHA1 Message Date
Brad King d625e832ed Merge topic 'cmake-parse-arguments-one-arg-empty-string'
ceeea4e511 cmake_parse_arguments: Set variable if empty string given after keyword
2f5cc6afa1 cmParseArgumentsCommand: Use cmStrCat() for string concatenation

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9748
2024-08-26 09:53:16 -04:00
Brad King de05bc2f15 Merge topic 'improve-CMakeLibTests'
cc20644c71 testCommon.h: Introduce `ASSERT_EQUAL(actual, expected)` macro

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9752
2024-08-26 09:50:43 -04:00
Brad King fe63f15383 Merge topic 'fileapi-config-dir'
1df94443fe fileapi: Add support for user-wide queries
a991a5019b Tests: Isolate test suite from user-wide configuration
320b81847d Tests: Remove unused cvs anonymous access credentials

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !9744
2024-08-26 09:48:40 -04:00
Brad King b448d7cc3a Merge branch 'release-3.30' 2024-08-26 09:46:37 -04:00
Brad King 7a3961cc94 Merge topic 'android-ndk-27'
24cd4ff844 Android: Fix build with NDK 27

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9766
2024-08-26 09:46:36 -04:00
Brad King bfa7a5445b Merge topic 'android-ndk-27' into release-3.30
24cd4ff844 Android: Fix build with NDK 27

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9766
2024-08-26 09:46:26 -04:00
Kitware Robot 70470acb84 CMake Nightly Date Stamp 2024-08-26 00:03:54 -04:00
Kitware Robot cfdc318c93 CMake Nightly Date Stamp 2024-08-25 00:01:11 -04:00
Kitware Robot 86f2af6173 CMake Nightly Date Stamp 2024-08-24 00:01:55 -04:00
Craig Scott d48834d277 Merge topic 'doc-get_property-undefined'
a1fdcb9d47 Help: get_property() result var is unset if property is not set
edee1b18b2 Help: Minor formatting and grammar fixes for get_property()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9769
2024-08-23 19:16:03 -04:00
Brad King 2233964cb1 Merge topic 'doc-if-conditions'
2e634501fd Help/command/if: list all condition operators in precedence order overview

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: scivision <michael@scivision.dev>
Merge-request: !9767
2024-08-23 09:50:12 -04:00
Brad King 1a817ba874 Merge topic 'ci-clang18-windows'
15dc1a357b ci: Update LLVM/Clang to 18.1 in nightly CI jobs on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9768
2024-08-23 09:47:48 -04:00
Kitware Robot 5022113bbe CMake Nightly Date Stamp 2024-08-23 00:01:22 -04:00
Craig Scott a1fdcb9d47 Help: get_property() result var is unset if property is not set
Fixes: #26152
2024-08-23 09:58:46 +10:00
Craig Scott edee1b18b2 Help: Minor formatting and grammar fixes for get_property() 2024-08-23 09:57:14 +10:00
Craig Scott ceeea4e511 cmake_parse_arguments: Set variable if empty string given after keyword
If a single-value keyword is followed by an empty string, the
command unsets the variable for that keyword instead of setting
it to the empty string. This is inconsistent and unexpected. Add
policy CMP0174 which ensures the variable for a single-value
keyword is always set when any value is given, not just for a
non-empty value.

The new CMP0174 policy only affects the PARSE_ARGV form of
cmake_parse_arguments. The older form silently drops all empty
string arguments before processing the argument list.

Fixes: #25972
2024-08-23 09:42:13 +10:00
Craig Scott 2f5cc6afa1 cmParseArgumentsCommand: Use cmStrCat() for string concatenation 2024-08-23 09:42:12 +10:00
Brad King 15dc1a357b ci: Update LLVM/Clang to 18.1 in nightly CI jobs on Windows 2024-08-22 11:47:50 -04:00
Aleksei Shpakovskii 2e634501fd Help/command/if: list all condition operators in precedence order overview
This section is near the top and so can serve as an exhaustive
table of contents for the things that `if()` can check.
2024-08-22 11:31:12 -04:00
Martin Duffy 1df94443fe fileapi: Add support for user-wide queries
Fixes: #19168
2024-08-22 10:24:23 -04:00
Brad King a991a5019b Tests: Isolate test suite from user-wide configuration 2024-08-22 09:59:35 -04:00
Brad King 320b81847d Tests: Remove unused cvs anonymous access credentials 2024-08-22 09:59:22 -04:00
Lars Schmertmann 24cd4ff844 Android: Fix build with NDK 27
`NDK_PROC_*_ABI` and `NDK_ARCH_*_ABI` were removed in the Android
NDK 27 but will be reintroduced in the Android NDK 27b:

* https://github.com/android/ndk/issues/2049
* https://android-review.googlesource.com/c/platform/ndk/+/3196345

Both are only used when `CMAKE_ANDROID_ARCH_ABI` is NOT given. But
currently the existence is also checked when `CMAKE_ANDROID_ARCH_ABI`
is given. So we move the checks to the position they are required.
2024-08-22 09:30:01 -04:00
Brad King 40e85e1551 Merge topic 'doc-if-IN_LIST'
e4a359e5d4 Help/command/if: Document variable expansion by IN_LIST

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9764
2024-08-22 09:06:00 -04:00
Brad King 0089d5ba72 Merge topic 'doc-target-COMPILE_FLAGS'
0f79ca336c Help: Target property COMPILE_FLAGS has been superseded by COMPILE_OPTIONS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9758
2024-08-22 09:05:00 -04:00
Brad King 4950445d4b Merge topic 'hip-lang-lib64search'
c34d827622 HIP: Ensure lib64 directories are included in hip-lang dependency search

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9741
2024-08-22 09:04:02 -04:00
Brad King 3d61720112 Merge topic 'autogen-predefs-emscripten'
8d1803d463 AutoGen: Run batch scripts using cmd.exe on windows platforms explicitly
9ab270f47d cmSystemTools: Add GetComspec method to get cmd on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9733
2024-08-22 09:03:05 -04:00
Kitware Robot 497b43b997 CMake Nightly Date Stamp 2024-08-22 00:01:17 -04:00
Brad King e4a359e5d4 Help/command/if: Document variable expansion by IN_LIST
Previously this behavior was only mentioned implicitly by the command
signature.  Describe it explicitly as we do for other conditions that
automatically expand variables.

Fixes: #26234
2024-08-21 09:17:21 -04:00
Peter Kokot 0f79ca336c Help: Target property COMPILE_FLAGS has been superseded by COMPILE_OPTIONS
The `COMPILE_FLAGS` is not actually deprecated but has been superseded
by the `COMPILE_OPTIONS` target property.
2024-08-21 08:56:06 -04:00
Brad King 8dcb35911c Merge topic 'test-cleanup'
4a259d82ad Templates: Remove unused and undocumented CTestScript.cmake.in
84f5f4278f Modules: Remove unnecessary .NoDartCoverage file in build tree

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !9760
2024-08-21 08:55:00 -04:00
Brad King d81a2e4f5e Merge topic 'cpack-pkg-c_str'
1393b31635 cmCPackPKGGenerator: Remove redundant call to c_str

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9759
2024-08-21 08:54:14 -04:00
Brad King 65ff215c15 Merge branch 'release-3.30' 2024-08-21 08:50:31 -04:00
Brad King 9e4bba8e12 Merge topic 'ci-xcode-15.4'
a05de59029 gitlab-ci: update macOS jobs to use Xcode 15.4

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9761
2024-08-21 08:50:31 -04:00
Brad King 0e217de343 Merge topic 'ci-xcode-15.4' into release-3.30
a05de59029 gitlab-ci: update macOS jobs to use Xcode 15.4

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9761
2024-08-21 08:50:23 -04:00
Brad King 43606e6d26 Merge branch 'release-3.30' 2024-08-21 08:47:10 -04:00
Brad King 07753f064c Merge topic 'ci-msvc-14.41'
c89ddecb94 gitlab-ci: Update Windows builds to MSVC 14.41 toolset

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9763
2024-08-21 08:47:10 -04:00
Brad King 3b8e86d121 Merge topic 'ci-msvc-14.41' into release-3.30
c89ddecb94 gitlab-ci: Update Windows builds to MSVC 14.41 toolset

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9763
2024-08-21 08:47:08 -04:00
Alexey Edelev 8d1803d463 AutoGen: Run batch scripts using cmd.exe on windows platforms explicitly
The CreateProcessW function requires to use the cmd.exe when
attempting to execute batch scripts. AutoMoc RunProcess relies on
CreateProcessW in it's internals. Currently the cmd.exe run happens
implicitly for batch files(perhaps by luck), but this is not
documented anywhere.

This replaces the .bat files in the AutoGen related command lines with
explicit 'cmd.exe /c' call. Also 'cmd.exe /c' has own limitation
related to the arguments. The very first argument shouldn't be quoted
otherwise this lead to the parsing issues. So for the .bat files that
contain spaces in their paths use short name conversion.

Fixes #26208
2024-08-21 11:05:19 +02:00
Alexey Edelev 9ab270f47d cmSystemTools: Add GetComspec method to get cmd on Windows
The function attempts to read the path to cmd executable from the
COMSPEC environment variable. Falls back to cmd.exe if the respective
environment variable is not set or path doesn't exist.
2024-08-21 11:05:16 +02:00
Kitware Robot f1bf0d6a49 CMake Nightly Date Stamp 2024-08-21 00:01:38 -04:00
Alex Turbov cc20644c71 testCommon.h: Introduce ASSERT_EQUAL(actual, expected) macro
Performs `==` on given arguments and print an error if they are
not equal also printing their values.

Both arguments must be printable to `std::ostream`!
2024-08-21 02:24:16 +04:00
Brad King c89ddecb94 gitlab-ci: Update Windows builds to MSVC 14.41 toolset 2024-08-20 15:27:43 -04:00
Brad King a05de59029 gitlab-ci: update macOS jobs to use Xcode 15.4 2024-08-20 14:58:19 -04:00
Brad King 4a259d82ad Templates: Remove unused and undocumented CTestScript.cmake.in
The file was added by commit 3006560d86 (ENH: Add template of ctest
script, 2006-04-28, v2.6.0~3433), but we do not use it for anything.
Technically it was public-facing by being in the `Templates/` directory,
but was never documented.
2024-08-20 13:20:11 -04:00
Brad King 84f5f4278f Modules: Remove unnecessary .NoDartCoverage file in build tree
In-source builds were accidentally installing it as part of the source
tree's `Modules` directory.  The file was added by commit e131bfb462
(bug fix and some cleanup, 2002-12-03, v2.4.0~4793), but we have no
`Modules` in the build tree anyway.
2024-08-20 13:20:10 -04:00
Rose 1393b31635 cmCPackPKGGenerator: Remove redundant call to c_str
The call is unnecessary since commit 438809d3ba (cmCPackGenerator: Add
option to FindTemplate to use alternate builtin path, 2024-03-06,
v3.30.0-rc1~353^2~4).
2024-08-20 11:58:28 -04:00
Brad King 041a482079 Merge topic 'vector-reserve-and-emplace'
abc8410ac7 cmInstallScriptHandler: Reserve and emplace vector entries

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9753
2024-08-20 11:53:49 -04:00
Brad King 52fc175d66 Merge topic 'string-swap-noexcept'
873b8244f0 String: Make swap method noexcept

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9754
2024-08-20 11:52:00 -04:00
Brad King be881e89a8 Merge topic 'optimize-stream-shift-operators'
5b259985bf Refactor: Optimize some `std::ostream::operator<<()` calls

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !9717
2024-08-20 11:51:10 -04:00