The CTestTestCrash tries to force a crash by dereferencing a NULL
pointer. The oneAPI 2021.4 C compiler notices that the pointer and the
value fetched from the pointer are never used and optimizes away the
dereferencing of the NULL pointer, which prevents the crash, causing
the test to fail.
This change adds the `volatile` keyword the pointer to prevent the
compiler optimizing it away. Removing a reference to a `volatile`
variable is illegal because access to a `volatile` variable could have
side effects not observable by the compiler.
Signed-off-by: William R. Dieter <william.r.dieter@intel.com>
Run the `Utilities/Scripts/clang-format.bash` script to update
all our C++ code to a new style defined by `.clang-format`.
Use `clang-format` version 3.8.
* If you reached this commit for a line in `git blame`, re-run the blame
operation starting at the parent of this commit to see older history
for the content.
* See the parent commit for instructions to rebase a change across this
style transition commit.
1: The CTestTestFailedSubmits tests do not need to run the
CTEST_MEMCHECK command. It is covered by the CTestTest2
test. If more coverage *is* required, choose a test that
runs by itself once to add it to... This one gets used
several times in a loop to test submission failure via
the various submission protocols. With memchecking on,
each test here takes 1000 seconds or more on a "fast"
build...
2: Other ctest tests do not need any of the CTEST_MEMORYCHECK_*
variables defined. They don't even call CTEST_MEMCHECK, or
-D NightlyMemCheck, or anything. So: remove the unnecessary
set calls.
3: CTestTest3 has gone intentionally unused for months because
it did not add any coverage and caused no ends of sporadic
randomish failures when network connectivity was spotty.
Remove its directory. Never add it again.
