mirror of
https://github.com/Kitware/CMake.git
synced 2026-01-04 21:00:17 -06:00
dd2f814Merge branch 'dev/add_test-working-directory' into dev/strict-mode949d32cUnwatch manual variables upon removal in cmake-gui3939032Unwatch manual variables upon removal in ccmake8354413Add method to unwatch a manual variable8ed3c85Give a better message for unused variables729db48Fix ArgumentExpansion test expected results89c2544Checking for a definition is a usage5625deeDon't output to stderr in the GUIad25a96Merge branch 'ImprovedDotSupport2' into dev/strict-modec128abeMerge branch 'AddCMAKE_CURRENT_LIST_DIR' into dev/strict-mode9bcaff0Merge branch 'cmake-guiRememberAdvancedCheckbox' into dev/strict-mode544d0c3Fix expected output for WarnUninitialized test4e3bea4Update expected messages to new format8e8c9e4Don't check at destruction for usage668e005Use cmake::IssueMessage for warnings88cd4c1Use 'CMake Warning' versus 'warning' for CDash3c3b98dInitialize the class before setting warn flagscf8b15aIgnore files under the CMakeFiles directoryfd50f06Don't check for unused vars at configure time447a04cDon't warn during configure when doing everythingb97ee21Check for unused variables at the end of generatec18c977When checking for variables, specify a reason3f1121fUse a long int since Line is a long as well2507f93Change the failure case string to 'Unexpected'fe390a2Add 'ArgumentExpansion' test8dbb209Wrong boolean value for CLI warningsd4ee998Hard-code the --no-warn-unused-cli flaga267b99Fix line lengths82ed104Flag that the directories have been set5aa535bAdd argument to arg parsing to not set directories367e5c3Revert "Revert "When calling CMake, set the args and the cache""ab5d4e4Revert "When calling CMake, set the args and the cache"9b90040When calling CMake, set the args and the cachefe56002Fix long lines for KWStyle5d30cfcSet a watch on variables added through the gui33c63b1Add a method to put a watch for variables535253fInitialize the warning variables earliercbb286cFix the path detection to work for top-level62be1f7Initialize the usage stack earlierc6e7fabFactor out the checks for unused variables5e41ba8When using the API, check for Add vs. Removedee1976Fix typo in VariableUnusedViaUnset testf231ce5Remove old false positive avoidance codea117e02Revert "Add test for unused warnings at the end of scope"2c82f2bExempt CMAKE(CURRENT|PARENT)_LIST_FILE from usage6d7d449Ignore CLI warnings for ABI determination7740a73Only return local keys that are definedbef3aeeUse the API so that warnings can be tracked05cb0f4Check for unused variables in the dtor91c4c99Add test for unused warnings at the end of scopeca90f67Fix detection of unused variables when settingf7438caAdd test for unused detection via setting it995cfb0Don't warn if the variable wasn't definedaefc91dAdd test for usage checks via unseta8e97f8Remove VarRemoved code since it's been superceded59463efRework CheckVariableForUnused usagef117423Fix line lengths to be no more than 78e49a935Improve unused warning logice01e40cMark ARGC, ARGV*, and ARGN as useda17aff7Ignore CMAKE_MATCH_* variables for usage02a114dAdd method to allow variables to be marked as useda0b0d23CMAKE_DO_TRY_COMPILE is no longer usedae3eff3Fix the path used for ignoring system warnings056b441Fix missing case for usage of a variable980e048Factor out checks for unused variables83acb0aRemove now unused variables3801463Use built-ins for readability and maintainability8b52015Push the initialize and unused states when copying439877fBe consistent with single and double quotes4cf1706Add documentation for check-system-varsb74777fFix the spelling of the flag for warn-unused-varsb948120Change logic of flag to turn off cli unused checksf047a17Add test for uninitialized variables75bda38Add tests for unused command line variables300fc15Fix detection of system filesd784e6aRun the unused variables check on the final pass9efc057VariableWatch is not available when bootstrapping2e78224Add a missing comma to the warning message7499700Add a flag to warn about system filesfff9f6dRename flags again and use variablewatch for cli786e269Add warn-unused to the Qt interface636e6c4Default to marking things as used4ff0340Rename find-unused to warn-unusedd7999e9Rename strict-mode to warn-uninitializede141bc9Detect unused variablesd3e8eb5Add flags to detect unused variablesf332e14Complete strict-mode checks for uninitialized vars52f9637Add method to get the local scope variablesf794d58Make --strict-mode option, and integrate with cmake-gui48b5b85Add a warning when variables are used uninitialized.cd626eaFor macros make sure the FilePath points to a valid pointer in the args.
For more information about how to contribute modules to CMake, see this page:
http://www.itk.org/Wiki/CMake:Module_Maintainers
Note to authors of FindXXX.cmake files
We would like all FindXXX.cmake files to produce consistent variable names.
Please use the following consistent variable names for general use.
XXX_INCLUDE_DIRS The final set of include directories listed in one variable for use by client code. This should not be a cache entry.
XXX_LIBRARIES The libraries to link against to use XXX. These should include full paths. This should not be a cache entry.
XXX_DEFINITIONS Definitions to use when compiling code that uses XXX. This really shouldn't include options such as (-DHAS_JPEG)that a client source-code file uses to decide whether to #include <jpeg.h>
XXX_EXECUTABLE Where to find the XXX tool.
XXX_YYY_EXECUTABLE Where to find the YYY tool that comes with XXX.
XXX_LIBRARY_DIRS Optionally, the final set of library directories listed in one variable for use by client code. This should not be a cache entry.
XXX_ROOT_DIR Where to find the base directory of XXX.
XXX_VERSION_YY Expect Version YY if true. Make sure at most one of these is ever true.
XXX_WRAP_YY If False, do not try to use the relevent CMake wrapping command.
XXX_YY_FOUND If False, optional YY part of XXX sytem is not available.
XXX_FOUND Set to false, or undefined, if we haven't found, or don't want to use XXX.
XXX_RUNTIME_LIBRARY_DIRS Optionally, the runtime library search path for use when running an executable linked to shared libraries.
The list should be used by user code to create the PATH on windows or LD_LIBRARY_PATH on unix.
This should not be a cache entry.
XXX_VERSION_STRING A human-readable string containing the version of the package found, if any.
XXX_VERSION_MAJOR The major version of the package found, if any.
XXX_VERSION_MINOR The minor version of the package found, if any.
XXX_VERSION_PATCH The patch version of the package found, if any.
You do not have to provide all of the above variables. You should provide XXX_FOUND under most circumstances. If XXX is a library, then XXX_LIBRARIES, should also be defined, and XXX_INCLUDE_DIRS should usually be defined (I guess libm.a might be an exception)
The following names should not usually be used in CMakeLists.txt files, but they may be usefully modified in users' CMake Caches to control stuff.
XXX_LIBRARY Name of XXX Library. A User may set this and XXX_INCLUDE_DIR to ignore to force non-use of XXX.
XXX_YY_LIBRARY Name of YY library that is part of the XXX system. It may or may not be required to use XXX.
XXX_INCLUDE_DIR Where to find xxx.h, etc. (XXX_INCLUDE_PATH was considered bad because a path includes an actual filename.)
XXX_YY_INCLUDE_DIR Where to find xxx_yy.h, etc.
For tidiness's sake, try to keep as many options as possible out of the cache, leaving at least one option which can be used to disable use of the module, or locate a not-found library (e.g. XXX_ROOT_DIR). For the same reason, mark most cache options as advanced.
If you need other commands to do special things then it should still begin with XXX_. This gives a sort of namespace effect and keeps things tidy for the user. You should put comments describing all the exported settings, plus descriptions of any the users can use to control stuff.
You really should also provide backwards compatibility any old settings that were actually in use. Make sure you comment them as deprecated, so that no-one starts using them.
To correctly document a module, create a comment block at the top with # comments. There are three types of comments that can be in the block:
1. The brief description of the module, this is done by:
# - a small description
2. A paragraph of text. This is done with all text that has a single
space between the # and the text. To create a new paragraph, just
put a # with no text on the line.
3. A verbatim line. This is done with two spaces between the # and the text.
For example:
# - This is a cool module
# This module does really cool stuff.
# It can do even more than you think.
#
# It even needs to paragraphs to tell you about it.
# And it defines the following variables:
# VAR_COOL - this is great isn't it?
# VAR_REALLY_COOL - cool right?
#
To have a .cmake file in this directory NOT show up in the
modules documentation, you should start the file with a blank
line.
A FindXXX.cmake module will typically be loaded by the command
FIND_PACKAGE(XXX [major[.minor[.patch[.tweak]]]] [EXACT]
[QUIET] [[REQUIRED|COMPONENTS] [components...]])
If any version numbers are given to the command it will set the
following variables before loading the module:
XXX_FIND_VERSION = full requested version string
XXX_FIND_VERSION_MAJOR = major version if requested, else 0
XXX_FIND_VERSION_MINOR = minor version if requested, else 0
XXX_FIND_VERSION_PATCH = patch version if requested, else 0
XXX_FIND_VERSION_TWEAK = tweak version if requested, else 0
XXX_FIND_VERSION_COUNT = number of version components, 0 to 4
XXX_FIND_VERSION_EXACT = true if EXACT option was given
If the find module supports versioning it should locate a version of
the package that is compatible with the version requested. If a
compatible version of the package cannot be found the module should
not report success. The version of the package found should be stored
in "XXX_VERSION..." version variables documented by the module.
If the QUIET option is given to the command it will set the variable
XXX_FIND_QUIETLY to true before loading the FindXXX.cmake module. If
this variable is set the module should not complain about not being
able to find the package. If the
REQUIRED option is given to the command it will set the variable
XXX_FIND_REQUIRED to true before loading the FindXXX.cmake module. If
this variable is set the module should issue a FATAL_ERROR if the
package cannot be found. For each package-specific component, say
YYY, listed after the REQUIRED option a variable XXX_FIND_REQUIRED_YYY
to true. The set of components listed after either the REQUIRED
option or the COMPONENTS option will be specified in a
XXX_FIND_COMPONENTS variable. This can be used by the FindXXX.cmake
module to determine which sub-components of the package must be found.
If neither the QUIET nor REQUIRED options are given then the
FindXXX.cmake module should look for the package and complain without
error if the module is not found.
To get this behaviour you can use the FIND_PACKAGE_HANDLE_STANDARD_ARGS()
macro, as an example see FindJPEG.cmake.
For internal implementation, it's a generally accepted convention that variables starting with
underscore are for temporary use only. (variable starting with an underscore
are not intended as a reserved prefix).