mirror of
https://github.com/Kitware/CMake.git
synced 2026-01-06 05:40:54 -06:00
In cmMakefile::PushScope, a copy of the closure of keys initialized in the parent scope is made. In PopScope, essentially the same copy is inserted back into the parent. That means a lot of duplication of strings and a lot of string comparisons. None of it is needed, because the cmDefinitions keys already provide a canonical representation of what is initialized. The removal of the separate container also makes the variable handling code more easy to reason about in general. Before this patch, configuring llvm uses 200 KiB for the VarInitStack. Overall peak memory consumption goes from 35.5 MiB to 35.1 MiB.
148 lines
4.2 KiB
C++
148 lines
4.2 KiB
C++
/*============================================================================
|
|
CMake - Cross Platform Makefile Generator
|
|
Copyright 2000-2009 Kitware, Inc., Insight Software Consortium
|
|
|
|
Distributed under the OSI-approved BSD License (the "License");
|
|
see accompanying file Copyright.txt for details.
|
|
|
|
This software is distributed WITHOUT ANY WARRANTY; without even the
|
|
implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
|
|
See the License for more information.
|
|
============================================================================*/
|
|
#include "cmDefinitions.h"
|
|
|
|
#include <assert.h>
|
|
|
|
//----------------------------------------------------------------------------
|
|
cmDefinitions::Def cmDefinitions::NoDef;
|
|
|
|
//----------------------------------------------------------------------------
|
|
cmDefinitions::Def const& cmDefinitions::GetInternal(
|
|
const std::string& key, StackIter begin, StackIter end, bool raise)
|
|
{
|
|
assert(begin != end);
|
|
MapType::const_iterator i = begin->Map.find(key);
|
|
if (i != begin->Map.end())
|
|
{
|
|
return i->second;
|
|
}
|
|
StackIter it = begin;
|
|
++it;
|
|
if (it == end)
|
|
{
|
|
return cmDefinitions::NoDef;
|
|
}
|
|
Def const& def = cmDefinitions::GetInternal(key, it, end, raise);
|
|
if (!raise)
|
|
{
|
|
return def;
|
|
}
|
|
return begin->Map.insert(MapType::value_type(key, def)).first->second;
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
const char* cmDefinitions::Get(const std::string& key,
|
|
StackIter begin, StackIter end)
|
|
{
|
|
Def const& def = cmDefinitions::GetInternal(key, begin, end, false);
|
|
return def.Exists? def.c_str() : 0;
|
|
}
|
|
|
|
void cmDefinitions::Raise(const std::string& key,
|
|
StackIter begin, StackIter end)
|
|
{
|
|
cmDefinitions::GetInternal(key, begin, end, true);
|
|
}
|
|
|
|
bool cmDefinitions::HasKey(const std::string& key,
|
|
StackConstIter begin, StackConstIter end)
|
|
{
|
|
for (StackConstIter it = begin; it != end; ++it)
|
|
{
|
|
MapType::const_iterator i = it->Map.find(key);
|
|
if (i != it->Map.end())
|
|
{
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
void cmDefinitions::Set(const std::string& key, const char* value)
|
|
{
|
|
Def def(value);
|
|
this->Map[key] = def;
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
std::vector<std::string> cmDefinitions::LocalKeys() const
|
|
{
|
|
std::vector<std::string> keys;
|
|
keys.reserve(this->Map.size());
|
|
// Consider local definitions.
|
|
for(MapType::const_iterator mi = this->Map.begin();
|
|
mi != this->Map.end(); ++mi)
|
|
{
|
|
if (mi->second.Exists)
|
|
{
|
|
keys.push_back(mi->first);
|
|
}
|
|
}
|
|
return keys;
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
cmDefinitions cmDefinitions::MakeClosure(StackConstIter begin,
|
|
StackConstIter end)
|
|
{
|
|
cmDefinitions closure;
|
|
std::set<std::string> undefined;
|
|
for (StackConstIter it = begin; it != end; ++it)
|
|
{
|
|
// Consider local definitions.
|
|
for(MapType::const_iterator mi = it->Map.begin();
|
|
mi != it->Map.end(); ++mi)
|
|
{
|
|
// Use this key if it is not already set or unset.
|
|
if(closure.Map.find(mi->first) == closure.Map.end() &&
|
|
undefined.find(mi->first) == undefined.end())
|
|
{
|
|
if(mi->second.Exists)
|
|
{
|
|
closure.Map.insert(*mi);
|
|
}
|
|
else
|
|
{
|
|
undefined.insert(mi->first);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return closure;
|
|
}
|
|
|
|
//----------------------------------------------------------------------------
|
|
std::vector<std::string>
|
|
cmDefinitions::ClosureKeys(StackConstIter begin, StackConstIter end)
|
|
{
|
|
std::set<std::string> bound;
|
|
std::vector<std::string> defined;
|
|
|
|
for (StackConstIter it = begin; it != end; ++it)
|
|
{
|
|
defined.reserve(defined.size() + it->Map.size());
|
|
for(MapType::const_iterator mi = it->Map.begin();
|
|
mi != it->Map.end(); ++mi)
|
|
{
|
|
// Use this key if it is not already set or unset.
|
|
if(bound.insert(mi->first).second && mi->second.Exists)
|
|
{
|
|
defined.push_back(mi->first);
|
|
}
|
|
}
|
|
}
|
|
|
|
return defined;
|
|
}
|