mirror of
https://github.com/Kitware/CMake.git
synced 2026-01-01 19:30:13 -06:00
95210d027a
The `FRAMEWORK` target property affects the way the `install()` command
treats the target and so should be set first. Our implementation
assumed that this was always the case and led to an assertion failure.
Prior to CMake 3.12 this was visible only when using an explicit
`LIBRARY ... NAMELINK_ONLY` option, but commit 0212d7c762 (install: add
NAMELINK_COMPONENT argument, 2018-04-18, v3.12.0-rc1~139^2~3) made
it possible with a simple `LIBRARY DESTINATION`.
Fully supporting out-of-order specification will require non-trivial
refactoring to defer install generator creation to generate time.
For now simply restore the old behavior of installing the framework
to the library destination and warn about the case.
Fixes: #18848
40 lines
1.5 KiB
CMake
40 lines
1.5 KiB
CMake
include(RunCMake)
|
|
|
|
run_cmake(InstallBeforeFramework)
|
|
|
|
function(framework_layout_test Name Toolchain Type)
|
|
set(RunCMake_TEST_BINARY_DIR ${RunCMake_BINARY_DIR}/${Toolchain}${Type}FrameworkLayout-build)
|
|
set(RunCMake_TEST_NO_CLEAN 1)
|
|
set(RunCMake_TEST_OPTIONS "-DCMAKE_TOOLCHAIN_FILE=${RunCMake_SOURCE_DIR}/${Toolchain}.cmake")
|
|
list(APPEND RunCMake_TEST_OPTIONS "-DFRAMEWORK_TYPE=${Type}")
|
|
|
|
file(REMOVE_RECURSE "${RunCMake_TEST_BINARY_DIR}")
|
|
file(MAKE_DIRECTORY "${RunCMake_TEST_BINARY_DIR}")
|
|
|
|
run_cmake(FrameworkLayout)
|
|
run_cmake_command(${Name} ${CMAKE_COMMAND} --build .)
|
|
endfunction()
|
|
|
|
framework_layout_test(iOSFrameworkLayout-build ios SHARED)
|
|
framework_layout_test(iOSFrameworkLayout-build ios STATIC)
|
|
framework_layout_test(OSXFrameworkLayout-build osx SHARED)
|
|
framework_layout_test(OSXFrameworkLayout-build osx STATIC)
|
|
|
|
function(framework_type_test Toolchain Type)
|
|
set(RunCMake_TEST_BINARY_DIR ${RunCMake_BINARY_DIR}/${Toolchain}${Type}FrameworkType-build)
|
|
set(RunCMake_TEST_NO_CLEAN 1)
|
|
set(RunCMake_TEST_OPTIONS "-DCMAKE_TOOLCHAIN_FILE=${RunCMake_SOURCE_DIR}/${Toolchain}.cmake")
|
|
list(APPEND RunCMake_TEST_OPTIONS "-DFRAMEWORK_TYPE=${Type}")
|
|
|
|
file(REMOVE_RECURSE "${RunCMake_TEST_BINARY_DIR}")
|
|
file(MAKE_DIRECTORY "${RunCMake_TEST_BINARY_DIR}")
|
|
|
|
run_cmake(FrameworkLayout)
|
|
run_cmake_command(FrameworkType${Type}-build ${CMAKE_COMMAND} --build .)
|
|
endfunction()
|
|
|
|
framework_type_test(ios SHARED)
|
|
framework_type_test(ios STATIC)
|
|
framework_type_test(osx SHARED)
|
|
framework_type_test(osx STATIC)
|