Brad King
50fdaf8f1f
cmComputeLinkInformation: Track targets named by TARGET_OBJECTS sources
...
Since commit b6a5382217 (Ninja: depend on language module information
files directly, 2023-02-10, v3.27.0-rc1~502^2), the return value of
`cmCommonTargetGenerator::GetLinkedTargetDirectories` must account for
linked object libraries because they may provide modules (#25112 ).
These were added by commit b665966933 (cmComputeLinkInformation: track
OBJECT library dependencies, 2023-07-22, v3.27.1~5^2). However, targets
named by `$<TARGET_OBJECTS:...>` sources are also needed (#25365 ).
The latter were added by commit 22da18b995 (Fortran: Restore support for
TARGET_OBJECTS providing modules, 2023-10-27, v3.28.0-rc4~9^2) and
commit 035302b7e3 (cmComputeLinkDepends: also copy the target from
object link items, 2023-10-27, v3.28.0-rc4~9^2~2). However, their
approach added link entries not actually specified by projects. It also
incorrectly re-used `cmComputeLinkDepends::AddLinkObject` for object
library targets when it is meant for their individual object files.
These problems caused additional regressions (#25417 ). Revert the
implementation parts of those commits and leave behind an assertion and
comment to help avoid the mistake in the future. Instead, track targets
named by `$<TARGET_OBJECTS:...>` sources with a dedicated member.
Issue: #25112
Issue: #25365
Fixes : #25417
Co-authored-by: Ben Boeckel <ben.boeckel@kitware.com >
2023-11-14 14:50:08 -05:00
..
2023-08-24 13:05:45 -04:00
2023-07-17 10:30:25 -04:00
2023-09-29 09:25:01 -04:00
2023-05-22 16:51:15 -04:00
2023-05-25 09:43:54 -04:00
2023-05-09 09:56:41 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 16:41:59 +02:00
2023-05-31 09:35:25 -04:00
2023-06-05 06:20:50 -04:00
2023-07-27 11:07:21 -04:00
2023-05-30 09:46:12 -04:00
2023-10-06 09:08:35 -04:00
2023-04-05 17:54:55 +02:00
2023-03-23 15:19:26 -04:00
2023-05-30 16:41:59 +02:00
2023-05-30 16:41:59 +02:00
2023-06-07 10:12:57 -04:00
2023-05-15 22:26:36 -04:00
2023-05-26 14:48:22 +02:00
2023-04-29 09:54:31 +02:00
2023-03-30 09:18:53 -04:00
2023-04-26 10:03:53 -04:00
2023-03-30 09:18:53 -04:00
2023-04-26 10:03:53 -04:00
2023-04-26 10:03:53 -04:00
2023-03-29 10:41:19 -04:00
2023-03-30 09:18:53 -04:00
2023-03-29 10:41:19 -04:00
2023-03-29 10:41:19 -04:00
2023-03-29 10:41:19 -04:00
2023-07-06 08:11:34 -04:00
2023-05-22 17:14:54 -04:00
2023-06-05 06:20:50 -04:00
2023-11-14 14:50:08 -05:00
2023-05-16 10:46:35 -04:00
2023-11-14 14:50:08 -05:00
2023-11-14 14:50:08 -05:00
2023-11-14 14:50:08 -05:00
2023-11-14 14:50:08 -05:00
2023-05-22 17:14:54 -04:00
2023-05-30 09:46:12 -04:00
2023-04-29 09:54:31 +02:00
2023-04-29 09:54:31 +02:00
2023-05-30 16:41:59 +02:00
2023-05-22 16:51:15 -04:00
2023-04-29 09:54:31 +02:00
2023-05-22 17:15:45 -04:00
2023-05-18 08:34:31 -04:00
2023-05-18 08:34:31 -04:00
2023-06-29 13:25:51 -04:00
2023-05-30 09:46:12 -04:00
2023-07-13 08:44:52 -04:00
2023-07-13 08:44:52 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-07-12 10:09:21 -04:00
2023-05-30 09:46:12 -04:00
2023-05-31 10:57:11 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-04-29 09:54:31 +02:00
2023-04-29 09:54:31 +02:00
2023-05-03 17:08:07 +02:00
2023-05-22 16:51:15 -04:00
2023-05-22 16:51:15 -04:00
2023-09-12 14:46:36 -04:00
2023-05-15 22:26:36 -04:00
2023-04-29 09:54:31 +02:00
2023-04-05 16:12:15 -04:00
2023-05-31 10:57:11 -04:00
2023-04-24 10:41:10 +02:00
2023-05-31 10:57:11 -04:00
2023-05-05 12:42:23 -04:00
2023-05-31 10:57:11 -04:00
2023-04-24 10:41:10 +02:00
2023-05-19 09:56:07 -04:00
2023-04-24 10:41:10 +02:00
2023-05-30 16:41:59 +02:00
2023-04-24 10:41:10 +02:00
2023-06-05 06:20:50 -04:00
2023-06-05 06:20:50 -04:00
2023-05-19 12:10:20 +02:00
2023-06-05 06:20:50 -04:00
2023-06-05 06:20:50 -04:00
2023-04-29 09:54:31 +02:00
2023-08-07 19:17:29 -04:00
2023-04-24 10:41:10 +02:00
2023-04-24 10:41:10 +02:00
2023-05-30 16:41:59 +02:00
2023-04-29 09:54:31 +02:00
2023-04-29 09:54:31 +02:00
2023-05-30 16:41:59 +02:00
2023-03-17 21:35:30 +11:00
2023-04-29 09:54:31 +02:00
2023-05-03 17:08:07 +02:00
2023-04-29 09:54:31 +02:00
2023-05-04 09:39:06 -04:00
2023-09-12 14:02:23 -04:00
2023-08-17 12:07:41 +02:00
2023-09-05 18:12:25 -04:00
2023-09-05 18:12:25 -04:00
2023-05-22 17:15:58 -04:00
2023-08-15 09:53:41 -04:00
2023-05-22 17:14:54 -04:00
2023-06-01 14:43:26 -04:00
2023-06-01 14:43:26 -04:00
2023-05-22 16:50:51 -04:00
2023-07-09 11:04:29 -04:00
2023-05-03 17:08:07 +02:00
2023-05-03 17:08:07 +02:00
2023-05-22 16:51:15 -04:00
2023-08-02 11:53:48 -04:00
2023-06-22 11:22:08 -04:00
2023-08-10 09:34:50 -04:00
2023-08-10 09:34:50 -04:00
2023-08-10 09:59:25 -04:00
2023-08-10 09:34:50 -04:00
2023-04-29 09:54:31 +02:00
2023-06-22 11:22:08 -04:00
2023-06-22 11:22:08 -04:00
2023-08-10 09:33:20 -04:00
2023-08-10 09:33:20 -04:00
2023-05-30 17:44:43 -04:00
2023-04-24 10:41:10 +02:00
2023-04-29 09:54:31 +02:00
2023-03-30 12:05:09 -04:00
2023-04-24 10:41:10 +02:00
2023-04-29 09:54:31 +02:00
2023-04-29 09:54:31 +02:00
2023-04-29 09:54:31 +02:00
2023-04-29 09:54:31 +02:00
2023-03-29 15:19:47 -04:00
2023-03-31 08:02:20 -04:00
2023-03-29 10:41:19 -04:00
2023-03-29 10:41:19 -04:00
2023-03-29 10:41:19 -04:00
2023-04-24 10:41:10 +02:00
2023-05-11 10:24:18 +02:00
2023-05-11 10:24:18 +02:00
2023-08-04 09:52:08 +02:00
2023-08-17 12:07:41 +02:00
2023-08-17 12:07:41 +02:00
2023-04-24 10:41:10 +02:00
2023-04-24 10:41:10 +02:00
2023-05-02 17:47:04 +02:00
2023-05-02 17:47:04 +02:00
2023-08-15 10:23:54 -04:00
2023-05-04 19:34:36 +02:00
2023-05-04 19:34:36 +02:00
2023-05-04 19:34:36 +02:00
2023-06-08 11:05:11 -04:00
2023-05-03 17:08:07 +02:00
2023-05-30 17:44:43 -04:00
2023-05-31 09:35:25 -04:00
2023-05-30 16:41:59 +02:00
2023-05-04 19:34:36 +02:00
2023-05-22 17:15:58 -04:00
2023-06-08 11:05:11 -04:00
2023-05-16 10:46:35 -04:00
2023-05-30 16:41:59 +02:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-30 09:46:12 -04:00
2023-05-04 19:34:36 +02:00
2023-04-13 11:10:00 +02:00
2023-07-09 11:04:29 -04:00
2023-05-16 10:46:35 -04:00
2023-03-28 17:53:18 -04:00
2023-05-30 16:41:59 +02:00
2023-05-16 12:15:31 -04:00
2023-05-16 12:15:31 -04:00
2023-04-24 10:41:10 +02:00
2023-04-29 09:54:31 +02:00
2023-05-03 09:03:46 -04:00
2023-05-26 14:48:22 +02:00
2023-05-26 14:48:22 +02:00
2023-03-24 12:23:47 -04:00
2023-03-24 12:23:47 -04:00
2023-05-31 13:04:49 -04:00
2023-05-22 17:15:58 -04:00
2023-04-24 10:41:10 +02:00
2023-03-14 15:20:47 -04:00
2023-03-09 16:09:48 -05:00
2023-04-29 09:54:31 +02:00
2023-04-24 10:41:10 +02:00
2023-05-30 16:41:59 +02:00
2023-05-26 14:48:22 +02:00
2023-05-26 14:48:22 +02:00
2023-04-24 10:41:10 +02:00
2023-05-30 16:41:59 +02:00
2023-05-30 16:41:59 +02:00
2023-05-26 14:48:22 +02:00
2023-05-26 14:48:22 +02:00
2023-03-30 09:18:53 -04:00
2023-05-15 22:26:36 -04:00
2023-04-24 10:41:10 +02:00
2023-04-29 09:54:31 +02:00
2023-07-25 11:35:24 -04:00
2023-06-01 11:19:19 -04:00
2023-04-12 10:43:48 -04:00
2023-05-31 10:57:11 -04:00
2023-05-26 14:48:22 +02:00
2023-05-26 14:48:22 +02:00
2023-06-09 09:47:52 -04:00
2023-05-30 16:41:59 +02:00
2023-06-05 11:27:45 -04:00
2023-06-05 11:27:45 -04:00
2023-09-14 13:01:20 -04:00
2023-08-02 11:53:48 -04:00
2023-07-12 10:29:49 -04:00
2023-04-24 10:41:10 +02:00