mirror of
https://github.com/Kitware/CMake.git
synced 2026-01-03 04:10:05 -06:00
This changes `cmMakefile::AddDefinition` to take a `cm::string_view` as value argument instead of a `const char *`. Benefits are: - `std::string` can be passed to `cmMakefile::AddDefinition` directly without the `c_str()` plus string length recomputation fallback. - Lengths of literals passed to `cmMakefile::AddDefinition` can be computed at compile time. In various sources uses of `cmMakefile::AddDefinition` are adapted to avoid `std::string::c_str` calls and the `std::string` is passed directly. Uses of `cmMakefile::AddDefinition`, where a `nullptr` `const char*` might be passed to `cmMakefile::AddDefinition` are extended with `nullptr` checks.
53 lines
1.4 KiB
C++
53 lines
1.4 KiB
C++
/* Distributed under the OSI-approved BSD 3-Clause License. See accompanying
|
|
file Copyright.txt or https://cmake.org/licensing for details. */
|
|
#include "cmGetCMakePropertyCommand.h"
|
|
|
|
#include <set>
|
|
|
|
#include "cmAlgorithms.h"
|
|
#include "cmGlobalGenerator.h"
|
|
#include "cmMakefile.h"
|
|
#include "cmState.h"
|
|
|
|
class cmExecutionStatus;
|
|
|
|
// cmGetCMakePropertyCommand
|
|
bool cmGetCMakePropertyCommand::InitialPass(
|
|
std::vector<std::string> const& args, cmExecutionStatus&)
|
|
{
|
|
if (args.size() < 2) {
|
|
this->SetError("called with incorrect number of arguments");
|
|
return false;
|
|
}
|
|
|
|
std::string const& variable = args[0];
|
|
std::string output = "NOTFOUND";
|
|
|
|
if (args[1] == "VARIABLES") {
|
|
if (const char* varsProp = this->Makefile->GetProperty("VARIABLES")) {
|
|
output = varsProp;
|
|
}
|
|
} else if (args[1] == "MACROS") {
|
|
output.clear();
|
|
if (const char* macrosProp = this->Makefile->GetProperty("MACROS")) {
|
|
output = macrosProp;
|
|
}
|
|
} else if (args[1] == "COMPONENTS") {
|
|
const std::set<std::string>* components =
|
|
this->Makefile->GetGlobalGenerator()->GetInstallComponents();
|
|
output = cmJoin(*components, ";");
|
|
} else {
|
|
const char* prop = nullptr;
|
|
if (!args[1].empty()) {
|
|
prop = this->Makefile->GetState()->GetGlobalProperty(args[1]);
|
|
}
|
|
if (prop) {
|
|
output = prop;
|
|
}
|
|
}
|
|
|
|
this->Makefile->AddDefinition(variable, output);
|
|
|
|
return true;
|
|
}
|