mirror of
https://github.com/Kitware/CMake.git
synced 2026-02-09 08:40:11 -06:00
292ec157b6
The `ctest --test-load` option is implemented in `StartNextTests` by not starting any tests when the load is too high and instead sleeping and then returning. Prior to commit v3.11.0-rc1~117^2 (CTest: Re-implement test process handling using libuv, 2017-12-10) our outer loop in `RunTests` would immediately call `StartNextTests` again. However, now the `uv_run` loop may simply terminate if there are no tests running because no events are left pending. Fix this by converting the sleep in `StartNextTests` into a libuv timer that it starts instead. This avoids leaving `uv_run` with no pending events. In the case that there are other running tests this also allows CTest to detect when they finish even if it during the wait period where we previously slept. This regression was not caught by the test suite because it only verified that we do not start new tests when the load was too high and not that we proceed to start tests when the load drops. Revise the test suite to cover both. Fixes: #18338
78 lines
2.3 KiB
CMake
78 lines
2.3 KiB
CMake
include(RunCTest)
|
|
set(RunCMake_TEST_TIMEOUT 60)
|
|
|
|
set(CASE_CTEST_TEST_ARGS "")
|
|
set(CASE_CTEST_TEST_LOAD "")
|
|
|
|
function(run_ctest_test CASE_NAME)
|
|
set(CASE_CTEST_TEST_ARGS "${ARGN}")
|
|
run_ctest(${CASE_NAME})
|
|
endfunction()
|
|
|
|
run_ctest_test(TestQuiet QUIET)
|
|
|
|
# Tests for the 'Test Load' feature of ctest
|
|
#
|
|
# Spoof a load average value to make these tests more reliable.
|
|
set(ENV{__CTEST_FAKE_LOAD_AVERAGE_FOR_TESTING} 5)
|
|
|
|
# Verify that new tests are started when the load average falls below
|
|
# our threshold.
|
|
run_ctest_test(TestLoadPass TEST_LOAD 6)
|
|
|
|
# Verify that new tests are not started when the load average exceeds
|
|
# our threshold and that they then run once the load average drops.
|
|
run_ctest_test(TestLoadWait TEST_LOAD 2)
|
|
|
|
# Verify that when an invalid "TEST_LOAD" value is given, a warning
|
|
# message is displayed and the value is ignored.
|
|
run_ctest_test(TestLoadInvalid TEST_LOAD "ERR1")
|
|
|
|
# Verify that new tests are started when the load average falls below
|
|
# our threshold.
|
|
set(CASE_CTEST_TEST_LOAD 7)
|
|
run_ctest_test(CTestTestLoadPass)
|
|
|
|
# Verify that new tests are not started when the load average exceeds
|
|
# our threshold and that they then run once the load average drops.
|
|
set(CASE_CTEST_TEST_LOAD 4)
|
|
run_ctest_test(CTestTestLoadWait)
|
|
|
|
# Verify that when an invalid "CTEST_TEST_LOAD" value is given,
|
|
# a warning message is displayed and the value is ignored.
|
|
set(CASE_CTEST_TEST_LOAD "ERR2")
|
|
run_ctest_test(CTestTestLoadInvalid)
|
|
|
|
# Verify that the "TEST_LOAD" value has higher precedence than
|
|
# the "CTEST_TEST_LOAD" value
|
|
set(CASE_CTEST_TEST_LOAD "ERR3")
|
|
run_ctest_test(TestLoadOrder TEST_LOAD "ERR4")
|
|
|
|
unset(ENV{__CTEST_FAKE_LOAD_AVERAGE_FOR_TESTING})
|
|
unset(CASE_CTEST_TEST_LOAD)
|
|
|
|
function(run_TestChangeId)
|
|
set(CASE_TEST_PREFIX_CODE [[
|
|
set(CTEST_CHANGE_ID "<>1")
|
|
]])
|
|
|
|
run_ctest(TestChangeId)
|
|
endfunction()
|
|
run_TestChangeId()
|
|
|
|
function(run_TestOutputSize)
|
|
set(CASE_CTEST_TEST_ARGS EXCLUDE RunCMakeVersion)
|
|
set(CASE_TEST_PREFIX_CODE [[
|
|
set(CTEST_CUSTOM_MAXIMUM_PASSED_TEST_OUTPUT_SIZE 10)
|
|
set(CTEST_CUSTOM_MAXIMUM_FAILED_TEST_OUTPUT_SIZE 12)
|
|
]])
|
|
set(CASE_CMAKELISTS_SUFFIX_CODE [[
|
|
add_test(NAME PassingTest COMMAND ${CMAKE_COMMAND} -E echo PassingTestOutput)
|
|
add_test(NAME FailingTest COMMAND ${CMAKE_COMMAND} -E no_such_command)
|
|
]])
|
|
|
|
unset(ENV{CTEST_PARALLEL_LEVEL})
|
|
run_ctest(TestOutputSize)
|
|
endfunction()
|
|
run_TestOutputSize()
|