From a70959e4a66769604c9298a125d44a455b75aed3 Mon Sep 17 00:00:00 2001
From: Craig Lawson <craig.lawson@web-engineer.co.uk>
Date: Sun, 11 Jan 2026 22:36:05 +0000
Subject: [PATCH] Nitpick fix - ref - client/src/Pages/v1/Settings/index.jsx
 (1) 171-175: LGTM!

The Redux dispatch provides immediate UI feedback while the actual persistence happens on Save. This is the correct pattern for a server-persisted setting.

Minor note: The ?? value fallback is unreachable for showURL since newValue is always set to a boolean at line 96. Consider simplifying to dispatch(setShowURL(newValue)) for clarity, though the current code is functionally correct.
---
 client/src/Pages/v1/Settings/index.jsx | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/client/src/Pages/v1/Settings/index.jsx b/client/src/Pages/v1/Settings/index.jsx
index ea714c34a..23478e2e8 100644
--- a/client/src/Pages/v1/Settings/index.jsx
+++ b/client/src/Pages/v1/Settings/index.jsx
@@ -171,11 +171,7 @@ const Settings = () => {
 
 		// Update Redux immediately for UI feedback
 		if (name === "showURL") {
-			dispatch(setShowURL(newValue ?? value));
-		}
-	};
-
-	const handleSave = () => {
+		dispatch(setShowURL(newValue));
 		const { error } = settingsValidation.validate(settingsData.settings, {
 			abortEarly: false,
 		});