From abc28c9ee848ea5cfe29f15e7dde685630b96706 Mon Sep 17 00:00:00 2001
From: Alex Holliday <ajhollid@gmail.com>
Date: Sun, 24 Nov 2024 15:59:09 +0800
Subject: [PATCH] Add better status string generation

---
 Server/service/statusService.js             |  7 ++++++-
 Server/tests/services/statusService.test.js | 12 ++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/Server/service/statusService.js b/Server/service/statusService.js
index 4f7c1a4ce..06f0a7f0e 100644
--- a/Server/service/statusService.js
+++ b/Server/service/statusService.js
@@ -11,6 +11,11 @@ class StatusService {
 		this.SERVICE_NAME = "StatusService";
 	}
 
+	getStatusString = (status) => {
+		if (status === true) return "up";
+		if (status === false) return "down";
+		return "unknown";
+	};
 	/**
 	 * Updates the status of a monitor based on the network response.
 	 *
@@ -34,7 +39,7 @@ class StatusService {
 
 			this.logger.info({
 				service: this.SERVICE_NAME,
-				message: `${monitor.name} went from ${monitor.status === true ? "up" : "down"} to ${status === true ? "up" : "down"}`,
+				message: `${monitor.name} went from ${this.getStatusString(monitor.status)} to ${this.getStatusString(status)}`,
 				prevStatus: monitor.status,
 				newStatus: status,
 			});
diff --git a/Server/tests/services/statusService.test.js b/Server/tests/services/statusService.test.js
index 7330ab57f..1ac660e51 100644
--- a/Server/tests/services/statusService.test.js
+++ b/Server/tests/services/statusService.test.js
@@ -27,6 +27,18 @@ describe("StatusService", () => {
 		});
 	});
 
+	describe("getStatusString", () => {
+		it("should return 'up' if status is true", () => {
+			expect(statusService.getStatusString(true)).to.equal("up");
+		});
+		it("should return 'down' if status is false", () => {
+			expect(statusService.getStatusString(false)).to.equal("down");
+		});
+		it("should return 'unknown' if status is undefined or null", () => {
+			expect(statusService.getStatusString(undefined)).to.equal("unknown");
+		});
+	});
+
 	describe("updateStatus", async () => {
 		beforeEach(() => {
 			// statusService.insertCheck = sinon.stub().resolves;