From d842f93a19347df196ad7a3f45089e0502c37f92 Mon Sep 17 00:00:00 2001
From: mohadeseh safari <mohadeseh.safari1992@gmail.com>
Date: Sun, 6 Jul 2025 18:09:17 -0400
Subject: [PATCH] fix: Remove unnecessary local monitor state in
 InfrastructureMenu component

---
 .../Components/MonitorsTableMenu/index.jsx    | 28 +++----------------
 1 file changed, 4 insertions(+), 24 deletions(-)

diff --git a/client/src/Pages/Infrastructure/Monitors/Components/MonitorsTableMenu/index.jsx b/client/src/Pages/Infrastructure/Monitors/Components/MonitorsTableMenu/index.jsx
index 7a1c57d23..73216650b 100644
--- a/client/src/Pages/Infrastructure/Monitors/Components/MonitorsTableMenu/index.jsx
+++ b/client/src/Pages/Infrastructure/Monitors/Components/MonitorsTableMenu/index.jsx
@@ -1,6 +1,6 @@
 /* TODO I basically copied and pasted this component from the actionsMenu. Check how we can make it reusable */
 
-import { useRef, useState, useEffect } from "react";
+import { useRef, useState } from "react";
 import { useTheme } from "@emotion/react";
 import { useNavigate } from "react-router-dom";
 import { createToast } from "../../../../../Utils/toastUtils";
@@ -30,21 +30,11 @@ const InfrastructureMenu = ({ monitor, isAdmin, updateCallback }) => {
 	const anchor = useRef(null);
 	const [isOpen, setIsOpen] = useState(false);
 	const [isDialogOpen, setIsDialogOpen] = useState(false);
-	const [localMonitorState, setLocalMonitorState] = useState(monitor);
 	const theme = useTheme();
 	const [pauseMonitor] = usePauseMonitor();
 	const { t } = useTranslation();
 
-	// Update local state when monitor prop changes
-	useEffect(() => {
-		// Ensure we have a valid monitor object with default values for missing properties
-		if (monitor) {
-			setLocalMonitorState({
-				...monitor,
-				status: monitor.status || "active", // Default to active if status is undefined
-			});
-		}
-	}, [monitor]);
+
 
 	const openMenu = (e) => {
 		e.stopPropagation();
@@ -76,21 +66,11 @@ const InfrastructureMenu = ({ monitor, isAdmin, updateCallback }) => {
 
 	const handlePause = async () => {
 		try {
-			// Toggle the local state immediately for better UI responsiveness
-			setLocalMonitorState((prevState) => ({
-				...prevState,
-				status: prevState.status === "paused" ? "active" : "paused",
-			}));
-
 			// Pass updateCallback as triggerUpdate to the hook
 			await pauseMonitor({ monitorId: monitor.id, triggerUpdate: updateCallback });
 			// Toast is already displayed in the hook, no need to display it again
 		} catch (error) {
-			// Error handling is done in the hook - revert the local state on error
-			setLocalMonitorState((prevState) => ({
-				...prevState,
-				status: prevState.status === "paused" ? "active" : "paused",
-			}));
+			// Error handling is done in the hook
 		}
 	};
 
@@ -175,7 +155,7 @@ const InfrastructureMenu = ({ monitor, isAdmin, updateCallback }) => {
 							closeMenu(e);
 						}}
 					>
-						{localMonitorState?.status === "paused"
+						{monitor.status === "paused"
 							? t("resume", "Resume")
 							: t("pause", "Pause")}
 					</MenuItem>