From a8463e289c17f50f021193c6c2b3635bc2aa61ed Mon Sep 17 00:00:00 2001 From: John Andrews Date: Tue, 15 Aug 2023 09:33:09 +1200 Subject: [PATCH] FF-1069 - fixing issue extracting dvd_subtitle --- VideoNodes/Helpers/SubtitleHelper.cs | 2 +- VideoNodes/VideoNodes/SubtitleExtractor.cs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/VideoNodes/Helpers/SubtitleHelper.cs b/VideoNodes/Helpers/SubtitleHelper.cs index 63f693ea..38438011 100644 --- a/VideoNodes/Helpers/SubtitleHelper.cs +++ b/VideoNodes/Helpers/SubtitleHelper.cs @@ -29,7 +29,7 @@ internal class SubtitleHelper /// the subtitle codec /// true if the subtitle is an image based subtitle internal static bool IsImageSubtitle(string codec) - => Regex.IsMatch((codec ?? string.Empty).Replace("_", ""), "dvbsub|pgs|xsub|vobsub", RegexOptions.IgnoreCase); + => Regex.IsMatch((codec ?? string.Empty).Replace("_", ""), "dvbsub|pgs|xsub|vobsub|dvdsub", RegexOptions.IgnoreCase); /// /// Determines the appropriate subtitle codec for conversion based on the container type and current subtitle codec. diff --git a/VideoNodes/VideoNodes/SubtitleExtractor.cs b/VideoNodes/VideoNodes/SubtitleExtractor.cs index 0e0ba4b3..e75b27b6 100644 --- a/VideoNodes/VideoNodes/SubtitleExtractor.cs +++ b/VideoNodes/VideoNodes/SubtitleExtractor.cs @@ -117,6 +117,7 @@ public class SubtitleExtractor : EncodingNode OutputFile = OutputFile[0..^4]; OutputFile += "." + extension; + args.Logger?.ILog($"Extracting subtitle codec '{subTrack.Codec}' to '{OutputFile}'"); var extracted = ExtractSubtitle(args, FFMPEG, "0:s:" + subTrack.TypeIndex, OutputFile); if(extracted)