Yet more cleanup of Asset-related files

include/openspace/scene/asset.h

@@ -81,8 +81,7 @@ public:
 
     void addSynchronization(std::shared_ptr<ResourceSynchronization> synchronization);
     void clearSynchronizations();
-    const std::vector<std::shared_ptr<ResourceSynchronization>>&
-        ownSynchronizations() const;
+    std::vector<ResourceSynchronization*> ownSynchronizations() const;
 
     void syncStateChanged(ResourceSynchronization* sync,
         ResourceSynchronization::State state);

include/openspace/util/resourcesynchronization.h

@@ -68,9 +68,9 @@ public:
 
     State state() const;
     const std::string& name() const;
-    bool isResolved();
-    bool isRejected();
-    bool isSyncing();
+    bool isResolved() const;
+    bool isRejected() const;
+    bool isSyncing() const;
     CallbackHandle addStateChangeCallback(StateChangeCallback cb);
     void removeStateChangeCallback(CallbackHandle id);
 

include/openspace/util/synchronizationwatcher.h

@@ -53,12 +53,6 @@ public:
         ResourceSynchronization::StateChangeCallback callback;
     };
 
-    /*using SyncStateChangeCallback =
-        std::function<void(
-            std::shared_ptr<ResourceSynchronization>,
-            ResourceSynchronization::State
-        )>;*/
-
     WatchHandle watchSynchronization(
         std::shared_ptr<ResourceSynchronization> synchronization,
         ResourceSynchronization::StateChangeCallback callback