mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-01-05 19:19:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Clarify the comment after getting feedback from scnlib

Browse Source
This commit is contained in:
Alexander Bock
2024-05-20 09:52:23 +02:00
parent d4a509ecce
commit 1d002a270b
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
modules/space/kepler.cpp
View File

@@ -208,8 +208,7 @@ namespace {
if (e.find('.') == std::string::npos) {
e += ".0";
}
// @TODO(abock) The 'd' suffix can be removed when
// https://github.com/eliaskosunen/scnlib/issues/104 is fixed
// @TODO(abock, 2024-05-20) 'd' suffix is needed until scnlib updates to v3
auto res = scn::scan<int, double>(e, "{:2d}{}");
if (!res) {
throw ghoul::RuntimeError(std::format("Error parsing epoch '{}'", epoch));
@@ -337,8 +336,7 @@ namespace {
// We have the first form
int month = 0;
int days = 0;
// @TODO(abock) The 'd' suffix can be removed when
// https://github.com/eliaskosunen/scnlib/issues/104 is fixed
// @TODO(abock, 2024-05-20) 'd' suffix is needed until scnlib updates to v3
auto res = scn::scan<int, int, int, int, int, double>(
epoch, "{:4d}-{:2d}-{:2d}T{:2d}:{:2d}:{}"
);
@@ -352,8 +350,7 @@ namespace {
else if (pos == 8) {
// We have the second form
// @TODO(abock) The 'd' suffix can be removed when
// https://github.com/eliaskosunen/scnlib/issues/104 is fixed
// @TODO(abock, 2024-05-20) 'd' suffix is needed until scnlib updates to v3
auto res = scn::scan<int, int, int, int, double>(
epoch, "{:4d}-{:3d}T{:2d}:{:2d}:{}"
//date.year, date.nDays, date.hours, date.minutes, date.seconds