mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-02-25 22:39:04 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add new verifier to handle identifiers and update codegen to be able to use them (closes #2522)

Browse Source
This commit is contained in:
Alexander Bock
2023-03-11 13:18:12 +01:00
parent 21cb90b7f8
commit 23ee2ee5da
15 changed files with 132 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
tests/test_documentation.cpp
View File

@@ -57,6 +57,11 @@ TEST_CASE("Documentation: Constructor", "[documentation]") {
new StringVerifier,
Optional::No
);
doc.entries.emplace_back(
"IdentifierVerifier",
new IdentifierVerifier,
Optional::No
);
doc.entries.emplace_back(
"FileVerifier",
new FileVerifier,
@@ -279,6 +284,7 @@ TEST_CASE("Documentation: Initializer Constructor", "[documentation]") {
{"DoubleVerifier", new DoubleVerifier, Optional::No },
{"IntVerifier", new IntVerifier, Optional::No },
{"StringVerifier", new StringVerifier, Optional::No },
{"IdentifierVerifier", new IdentifierVerifier, Optional::No },
{"FileVerifier", new FileVerifier, Optional::No },
{"DirectoryVerifier", new DirectoryVerifier, Optional::No },
{"DateTimeVerifier", new DateTimeVerifier, Optional::No },
@@ -465,6 +471,69 @@ TEST_CASE("Documentation: StringVerifier", "[documentation]") {
CHECK(negativeRes.offenses[0].reason == TestResult::Offense::Reason::MissingKey);
}
TEST_CASE("Documentation: IdentifierVerifier", "[documentation]") {
using namespace openspace::documentation;
using namespace std::string_literals;
Documentation doc{
{{ "Identifier", new IdentifierVerifier, Optional::No }}
};
ghoul::Dictionary positive;
positive.setValue("Identifier", "abcdef"s);
TestResult positiveRes = testSpecification(doc, positive);
CHECK(positiveRes.success);
CHECK(positiveRes.offenses.empty());
ghoul::Dictionary negativeSpace;
negativeSpace.setValue("Identifier", "abc def"s);
TestResult negativeRes = testSpecification(doc, negativeSpace);
CHECK(!negativeRes.success);
REQUIRE(negativeRes.offenses.size() == 1);
CHECK(negativeRes.offenses[0].offender == "Identifier");
CHECK(negativeRes.offenses[0].reason == TestResult::Offense::Reason::Verification);
ghoul::Dictionary negativeTab;
negativeTab.setValue("Identifier", "abc\tdef"s);
negativeRes = testSpecification(doc, negativeTab);
CHECK(!negativeRes.success);
REQUIRE(negativeRes.offenses.size() == 1);
CHECK(negativeRes.offenses[0].offender == "Identifier");
CHECK(negativeRes.offenses[0].reason == TestResult::Offense::Reason::Verification);
ghoul::Dictionary negativeNewline;
negativeNewline.setValue("Identifier", "abc\ndef"s);
negativeRes = testSpecification(doc, negativeNewline);
CHECK(!negativeRes.success);
REQUIRE(negativeRes.offenses.size() == 1);
CHECK(negativeRes.offenses[0].offender == "Identifier");
CHECK(negativeRes.offenses[0].reason == TestResult::Offense::Reason::Verification);
ghoul::Dictionary negativeCarriageReturn;
negativeCarriageReturn.setValue("Identifier", "abc\rdef"s);
negativeRes = testSpecification(doc, negativeCarriageReturn);
CHECK(!negativeRes.success);
REQUIRE(negativeRes.offenses.size() == 1);
CHECK(negativeRes.offenses[0].offender == "Identifier");
CHECK(negativeRes.offenses[0].reason == TestResult::Offense::Reason::Verification);
ghoul::Dictionary negativeDot;
negativeDot.setValue("Identifier", "abc.def"s);
negativeRes = testSpecification(doc, negativeDot);
CHECK(!negativeRes.success);
REQUIRE(negativeRes.offenses.size() == 1);
CHECK(negativeRes.offenses[0].offender == "Identifier");
CHECK(negativeRes.offenses[0].reason == TestResult::Offense::Reason::Verification);
ghoul::Dictionary negativeType;
negativeType.setValue("Identifier", 0);
negativeRes = testSpecification(doc, negativeType);
CHECK_FALSE(negativeRes.success);
REQUIRE(negativeRes.offenses.size() == 1);
CHECK(negativeRes.offenses[0].offender == "Identifier");
CHECK(negativeRes.offenses[0].reason == TestResult::Offense::Reason::WrongType);
}
TEST_CASE("Documentation: FileVerifier", "[documentation]") {
using namespace openspace::documentation;
using namespace std::string_literals;