mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-02-25 06:19:02 -06:00
Code Issues Packages Projects Releases Wiki Activity

Pass through the code to address clang-tidy linting (#3083)

Browse Source
This commit is contained in:
Alexander Bock
2024-03-17 00:58:50 +01:00
committed by GitHub
parent 75681d1d4c
commit 2759c00e4b
457 changed files with 6639 additions and 6519 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
modules/server/servermodule.cpp
View File

@@ -96,9 +96,10 @@ void ServerModule::internalInitialize(const ghoul::Dictionary& configuration) {
if (!configuration.hasValue<ghoul::Dictionary>(KeyInterfaces)) {
return;
}
ghoul::Dictionary interfaces = configuration.value<ghoul::Dictionary>(KeyInterfaces);
const ghoul::Dictionary interfaces =
configuration.value<ghoul::Dictionary>(KeyInterfaces);
for (std::string_view key : interfaces.keys()) {
for (const std::string_view key : interfaces.keys()) {
ghoul::Dictionary interfaceDictionary = interfaces.value<ghoul::Dictionary>(key);
// @TODO (abock, 2019-09-17); This is a hack to make the parsing of the
@@ -143,7 +144,7 @@ void ServerModule::preSync() {
std::unique_ptr<ghoul::io::Socket> socket;
while ((socket = socketServer->nextPendingSocket())) {
std::string address = socket->address();
const std::string address = socket->address();
if (serverInterface->clientIsBlocked(address)) {
// Drop connection if the address is blocked.
continue;
@@ -200,7 +201,7 @@ void ServerModule::disconnectAll() {
serverInterface->deinitialize();
}
for (ConnectionData& connectionData : _connections) {
for (const ConnectionData& connectionData : _connections) {
Connection& connection = *connectionData.connection;
if (connection.socket() && connection.socket()->isConnected()) {
connection.socket()->disconnect(
@@ -210,13 +211,13 @@ void ServerModule::disconnectAll() {
}
}
void ServerModule::handleConnection(std::shared_ptr<Connection> connection) {
void ServerModule::handleConnection(const std::shared_ptr<Connection>& connection) {
ZoneScoped;
std::string messageString;
messageString.reserve(256);
while (connection->socket()->getMessage(messageString)) {
std::lock_guard lock(_messageQueueMutex);
const std::lock_guard lock(_messageQueueMutex);
_messageQueue.push_back({ connection, messageString });
}
}
@@ -224,19 +225,18 @@ void ServerModule::handleConnection(std::shared_ptr<Connection> connection) {
void ServerModule::consumeMessages() {
ZoneScoped;
std::lock_guard lock(_messageQueueMutex);
const std::lock_guard lock(_messageQueueMutex);
while (!_messageQueue.empty()) {
const Message& m = _messageQueue.front();
if (std::shared_ptr<Connection> c = m.connection.lock()) {
if (const std::shared_ptr<Connection>& c = m.connection.lock()) {
c->handleMessage(m.messageString);
}
_messageQueue.pop_front();
}
}
ServerModule::CallbackHandle ServerModule::addPreSyncCallback(CallbackFunction cb)
{
CallbackHandle handle = _nextCallbackHandle++;
ServerModule::CallbackHandle ServerModule::addPreSyncCallback(CallbackFunction cb) {
const CallbackHandle handle = _nextCallbackHandle++;
_preSyncCallbacks.emplace_back(handle, std::move(cb));
return handle;
}