mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-01-06 03:29:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

Allow negative values for KeplerTranslation values (#2784)

Browse Source
This commit is contained in:
Alexander Bock
2023-07-06 10:03:44 +02:00
committed by GitHub
parent 391c5ef3d1
commit 380f768e4c
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
modules/space/translation/keplertranslation.cpp
View File

@@ -121,16 +121,16 @@ namespace {
double semiMajorAxis;
// [[codegen::verbatim(InclinationInfo.description)]]
double inclination [[codegen::inrange(0.0, 360.0)]];
double inclination [[codegen::inrange(-360.0, 360.0)]];
// [[codegen::verbatim(AscendingNodeInfo.description)]]
double ascendingNode [[codegen::inrange(0.0, 360.0)]];
double ascendingNode [[codegen::inrange(-360.0, 360.0)]];
// [[codegen::verbatim(ArgumentOfPeriapsisInfo.description)]]
double argumentOfPeriapsis [[codegen::inrange(0.0, 360.0)]];
double argumentOfPeriapsis [[codegen::inrange(-360.0, 360.0)]];
// [[codegen::verbatim(MeanAnomalyAtEpochInfo.description)]]
double meanAnomaly [[codegen::inrange(0.0, 360.0)]];
double meanAnomaly [[codegen::inrange(-360.0, 360.0)]];
// [[codegen::verbatim(EpochInfo.description)]]
std::string epoch;
@@ -198,10 +198,12 @@ KeplerTranslation::KeplerTranslation(const ghoul::Dictionary& dictionary)
setKeplerElements(
p.eccentricity,
p.semiMajorAxis,
p.inclination,
p.ascendingNode,
p.argumentOfPeriapsis,
p.meanAnomaly,
p.inclination < 0.0 ? p.inclination + 360.0 : p.inclination,
p.ascendingNode < 0.0 ? p.ascendingNode + 360.0 : p.ascendingNode,
p.argumentOfPeriapsis < 0.0 ?
p.argumentOfPeriapsis + 360.0 :
p.argumentOfPeriapsis,
p.meanAnomaly < 0.0 ? p.meanAnomaly + 360.0 : p.meanAnomaly,
p.period,
p.epoch
);
@@ -329,7 +331,6 @@ void KeplerTranslation::setKeplerElements(double eccentricity, double semiMajorA
auto isInRange = [](double val, double min, double max) -> bool {
return val >= min && val <= max;
};
if (isInRange(eccentricity, 0.0, 1.0)) {
_eccentricity = eccentricity;
}