Start addressing PR comments

This commit is contained in:
Malin E
2022-08-26 16:58:48 +02:00
parent 40267804bd
commit 41d52f7f04
12 changed files with 141 additions and 134 deletions
@@ -25,7 +25,7 @@
#ifndef __OPENSPACE_MODULE_DIGITALUNIVERSE___RENDERABLECONSTELLATIONLINES___H__
#define __OPENSPACE_MODULE_DIGITALUNIVERSE___RENDERABLECONSTELLATIONLINES___H__
#include <modules/space/rendering/renderableconstellation.h>
#include <modules/space/rendering/renderableconstellationsbase.h>
#include <ghoul/opengl/uniformcache.h>
#include <unordered_map>
@@ -41,7 +41,7 @@ namespace openspace {
namespace documentation { struct Documentation; }
class RenderableConstellationLines : public RenderableConstellation {
class RenderableConstellationLines : public RenderableConstellationsBase {
public:
explicit RenderableConstellationLines(const ghoul::Dictionary& dictionary);
~RenderableConstellationLines() override = default;
@@ -88,7 +88,7 @@ private:
properties::BoolProperty _drawElements;
std::unique_ptr<ghoul::opengl::ProgramObject> _program = nullptr;
UniformCache(modelViewTransform, projectionTransform, alphaValue,
UniformCache(modelViewTransform, projectionTransform, opacity,
color) _uniformCache;
std::string _speckFile;