Code cleanup branch (#618)

* Make height map fallback layer work again
  * Add documentation to joystick button bindings
  * Removed grouped property headers
  * Add new version number constant generated by CMake
  * Make Joystick deadzone work properly
  * Change the startup date on Earth to today
  * Fix key modifier handling
  * Add debugging indices for TreeNodeDebugging
  * Fix script schedule for OsirisRex
  * Do not open Mission schedule automatically
  * Upload default projection texture automatically

  * General code cleanup
  * Fix check_style_guide warnings
  * Remove .clang-format
  * MacOS compile fixes
  * Clang analyzer fixes

modules/base/scale/staticscale.cpp

@@ -28,7 +28,7 @@
 #include <openspace/documentation/verifier.h>
 
 namespace {
-    static const openspace::properties::Property::PropertyInfo ScaleInfo = {
+    const openspace::properties::Property::PropertyInfo ScaleInfo = {
         "Scale",
         "Scale",
         "This value is used as a scaling factor for the scene graph node that this "
@@ -58,9 +58,7 @@ double StaticScale::scaleValue(const Time&) const {
     return _scaleValue;
 }
 
-StaticScale::StaticScale()
-    : _scaleValue(ScaleInfo, 1.0, 1.0, 1e6)
-{
+StaticScale::StaticScale() : _scaleValue(ScaleInfo, 1.0, 1.0, 1e6) {
     addProperty(_scaleValue);
 
     _scaleValue.onChange([this]() {
@@ -68,9 +66,7 @@ StaticScale::StaticScale()
     });
 }
 
-StaticScale::StaticScale(const ghoul::Dictionary& dictionary)
-    : StaticScale()
-{
+StaticScale::StaticScale(const ghoul::Dictionary& dictionary) : StaticScale() {
     documentation::testSpecificationAndThrow(Documentation(), dictionary, "StaticScale");
 
     _scaleValue = static_cast<float>(dictionary.value<double>(ScaleInfo.identifier));