diff --git a/apps/DocsWriter/main.cpp b/apps/DocsWriter/main.cpp index 1bfe2e79b2..219b784819 100644 --- a/apps/DocsWriter/main.cpp +++ b/apps/DocsWriter/main.cpp @@ -31,7 +31,7 @@ #include #include -int main(int argc, char** argv) { +int main(int, char** argv) { using namespace openspace; ghoul::logging::LogManager::initialize( diff --git a/modules/base/rendering/renderableplane.cpp b/modules/base/rendering/renderableplane.cpp index 1dd28e7938..e57aa6f94f 100644 --- a/modules/base/rendering/renderableplane.cpp +++ b/modules/base/rendering/renderableplane.cpp @@ -238,12 +238,12 @@ RenderablePlane::DistanceScalingSettings::DistanceScalingSettings( RenderablePlane::RenderablePlane(const ghoul::Dictionary& dictionary) : Renderable(dictionary, { .automaticallyUpdateRenderBin = false }) , _blendMode(BlendModeInfo) - , _distanceScalingSettings(dictionary) , _renderOption(OrientationRenderOptionInfo) , _mirrorBackside(MirrorBacksideInfo, false) , _size(SizeInfo, glm::vec2(10.f), glm::vec2(0.f), glm::vec2(1e25f)) , _autoScale(AutoScaleInfo, false) , _multiplyColor(MultiplyColorInfo, glm::vec3(1.f), glm::vec3(0.f), glm::vec3(1.f)) + , _distanceScalingSettings(dictionary) { const Parameters p = codegen::bake(dictionary); diff --git a/modules/telemetry/src/general/nodestelemetry_lua.inl b/modules/telemetry/src/general/nodestelemetry_lua.inl index b2107c50a9..5e6923dc24 100644 --- a/modules/telemetry/src/general/nodestelemetry_lua.inl +++ b/modules/telemetry/src/general/nodestelemetry_lua.inl @@ -44,7 +44,7 @@ namespace { } openspace::NodesTelemetry* nodesTelemetry = - reinterpret_cast(ptr); + dynamic_cast(ptr); for (const std::string_view& k : nodes.keys()) { std::string node = nodes.value(k); diff --git a/modules/telemetry/src/general/timetelemetry.cpp b/modules/telemetry/src/general/timetelemetry.cpp index 53d7a63081..34bf98f300 100644 --- a/modules/telemetry/src/general/timetelemetry.cpp +++ b/modules/telemetry/src/general/timetelemetry.cpp @@ -76,7 +76,7 @@ TimeTelemetry::TimeTelemetry(const std::string& ip, int port) , _precisionProperties(TimeTelemetry::PrecisionProperties(PrecisionInfo)) { for (size_t i = 0; i < TimeUnitNames.size(); ++i) { - _timeUnitOption.addOption(i, TimeUnitNames[i].singular.data()); + _timeUnitOption.addOption(static_cast(i), TimeUnitNames[i].singular.data()); } _timeUnitOption.setValue(static_cast(TimeUnit::Day)); diff --git a/modules/telemetry/src/specific/planetsoverviewsonification.cpp b/modules/telemetry/src/specific/planetsoverviewsonification.cpp index 17595925c6..6bf26e147f 100644 --- a/modules/telemetry/src/specific/planetsoverviewsonification.cpp +++ b/modules/telemetry/src/specific/planetsoverviewsonification.cpp @@ -28,8 +28,6 @@ #include namespace { - constexpr std::string_view _loggerCat = "PlanetsOverviewSonification"; - // Indices for data items constexpr int NumDataItems = 1; constexpr int GuiSettingsIndex = 0; diff --git a/modules/telemetry/src/telemetrybase.cpp b/modules/telemetry/src/telemetrybase.cpp index 0630f4b294..6090440669 100644 --- a/modules/telemetry/src/telemetrybase.cpp +++ b/modules/telemetry/src/telemetrybase.cpp @@ -30,14 +30,11 @@ #include namespace { - constexpr std::string_view _loggerCat = "TelemetryBase"; - constexpr openspace::properties::Property::PropertyInfo EnabledInfo = { "Enabled", "Enabled", "This setting determines whether this telemetry gathering is enabled or not.", openspace::properties::Property::Visibility::User - }; } // namespace @@ -46,8 +43,8 @@ namespace openspace { TelemetryBase::TelemetryBase(properties::PropertyOwner::PropertyOwnerInfo info, const std::string& ip, int port) : properties::PropertyOwner(info) - , _enabled(EnabledInfo, false) , _identifier(info.identifier) + , _enabled(EnabledInfo, false) , _connection(new OpenSoundControlConnection(ip, port)) { addProperty(_enabled); diff --git a/modules/telemetry/telemetrymodule.cpp b/modules/telemetry/telemetrymodule.cpp index 602845255c..a1fccb700f 100644 --- a/modules/telemetry/telemetrymodule.cpp +++ b/modules/telemetry/telemetrymodule.cpp @@ -43,8 +43,6 @@ #include namespace { - constexpr std::string_view _loggerCat = "TelemetryModule"; - // The default Open Sound Control receiver is SuperCollider with these default values. // However, the user can define any receiver in the openspace.cfg file as the // ModuleConfiguration for the Telemetry module. diff --git a/modules/webbrowser/src/webrenderhandler.cpp b/modules/webbrowser/src/webrenderhandler.cpp index 7bca0b334b..42abec216f 100644 --- a/modules/webbrowser/src/webrenderhandler.cpp +++ b/modules/webbrowser/src/webrenderhandler.cpp @@ -112,7 +112,7 @@ void WebRenderHandler::OnPaint(CefRefPtr, CefRenderHandler::PaintEle } #ifdef WIN32 -void WebRenderHandler::OnAcceleratedPaint(CefRefPtr browser, +void WebRenderHandler::OnAcceleratedPaint(CefRefPtr, PaintElementType, const RectList& dirtyRects, const CefAcceleratedPaintInfo& info)