mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-01-21 11:39:51 -06:00
Code Issues Packages Projects Releases Wiki Activity

Collection of a number of changes (#2286)

Browse Source 
* Cleanup Property code
* Remove NOLINT statements
* Return Property class types as string_view
* Remove getStringValue function
* Simplify string value retrieval
* Ensure that image paths in the ImageSequenceTileProvider are sorted (closes #2205)
* Some cleanup of OpenSpaceEngine
* Cleanup documentation
* Some more cleanup of engine classes
* Some more cleanup
* Update SGCT repository
* Use new Jenkins node identifiers as the old method broke with update
This commit is contained in:
Alexander Bock
2022-10-30 12:54:14 +01:00
committed by GitHub
parent 3862e1f449
commit 6249fa6d89
129 changed files with 467 additions and 761 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/engine/moduleengine.cpp
View File

@@ -92,7 +92,6 @@ void ModuleEngine::initialize(
}
addPropertySubOwner(m);
}
}
@@ -153,12 +152,11 @@ void ModuleEngine::registerModule(std::unique_ptr<OpenSpaceModule> mod) {
);
if (it != _modules.end()) {
throw ghoul::RuntimeError(
"Module name '" + mod->identifier() + "' was registered before",
fmt::format("Module name '{}' was registered before", mod->identifier()),
"ModuleEngine"
);
}
LDEBUG(fmt::format("Registering module '{}'", mod->identifier()));
LDEBUG(fmt::format("Registered module '{}'", mod->identifier()));
_modules.push_back(std::move(mod));
}