Add some analyzer suggestions

src/navigation/navigationhandler.cpp

@@ -194,14 +194,14 @@ void NavigationHandler::setInterpolationTime(float durationInSeconds) {
     _orbitalNavigator.setRetargetInterpolationTime(durationInSeconds);
 }
 
-void NavigationHandler::triggerFadeToTransition(const std::string& transitionScript,
+void NavigationHandler::triggerFadeToTransition(std::string transitionScript,
                                                 std::optional<float> fadeDuration)
 {
     const float duration = fadeDuration.value_or(_jumpToFadeDuration);
 
     std::string script;
     if (duration < std::numeric_limits<float>::epsilon()) {
-        script = transitionScript;
+        script = std::move(transitionScript);
     }
     else {
         const std::string onArrivalScript = std::format(

src/navigation/navigationhandler_lua.inl

@@ -1256,7 +1256,7 @@ localPositionFromGeoDeprecated(std::string nodeIdentifier, double latitude,
 
     bool setTime = (ns.timestamp.has_value() && useTimeStamp.value_or(false));
 
-    const std::string script = std::format(
+    std::string script = std::format(
         "openspace.navigation.setNavigationState({}, {})",
         ghoul::formatLua(ns.dictionary()), setTime
     );
@@ -1268,7 +1268,7 @@ localPositionFromGeoDeprecated(std::string nodeIdentifier, double latitude,
         );
     }
     else {
-        global::navigationHandler->triggerFadeToTransition(script);
+        global::navigationHandler->triggerFadeToTransition(std::move(script));
     }
 }
 
@@ -1288,7 +1288,7 @@ localPositionFromGeoDeprecated(std::string nodeIdentifier, double latitude,
         throw ghoul::lua::LuaError("Unknown node name: " + nodeIdentifier);
     }
 
-    const std::string script = std::format(
+    std::string script = std::format(
         "openspace.navigation.flyTo('{}', 0)", nodeIdentifier
     );
 
@@ -1299,7 +1299,7 @@ localPositionFromGeoDeprecated(std::string nodeIdentifier, double latitude,
         );
     }
     else {
-        global::navigationHandler->triggerFadeToTransition(script);
+        global::navigationHandler->triggerFadeToTransition(std::move(script));
     }
 }