CMake cleanup (#2489)

* CMake Cleanup
* Warning suppression with CEF
* Use SGCT tinyxml in skybrowser for now
* Disable warnings about missing field initializers

modules/server/CMakeLists.txt

@@ -22,7 +22,7 @@
 # OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.                                          #
 ##########################################################################################
 
-include(${OPENSPACE_CMAKE_EXT_DIR}/module_definition.cmake)
+include(${PROJECT_SOURCE_DIR}/support/cmake/module_definition.cmake)
 include_directories(${CMAKE_CURRENT_SOURCE_DIR})
 
 set(HEADER_FILES

modules/server/servermodule.cpp

@@ -56,7 +56,7 @@ ServerModule::ServerModule()
         // Trigger callbacks
         using K = CallbackHandle;
         using V = CallbackFunction;
-        for (const std::pair<const K, V>& it : _preSyncCallbacks) {
+        for (const std::pair<K, V>& it : _preSyncCallbacks) {
             it.second(); // call function
         }
     });

modules/server/src/topics/cameratopic.cpp

@@ -37,7 +37,6 @@
 
 namespace {
     constexpr std::string_view SubscribeEvent = "start_subscription";
-    constexpr std::string_view UnsubscribeEvent = "stop_subscription";
 } // namespace
 
 using nlohmann::json;