mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-01-06 11:39:49 -06:00
Code Issues Packages Projects Releases Wiki Activity

Feature/warnings (#1425)

Browse Source 
* Remove MSVC, GCC, Clang compiler warnings
* Remove cppcheck warnings
This commit is contained in:
Alexander Bock
2020-12-07 23:43:05 +01:00
committed by GitHub
parent 51470c0a0d
commit 86bb19d81c
94 changed files with 392 additions and 511 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/fitsfilereader/CMakeLists.txt
View File

@@ -59,10 +59,8 @@ add_subdirectory(${CCFITS_ROOT_DIR})
set_folder_location(CCfits "External")
set(CCfits_BUILD_SHARED_LIBS OFF)
if (GHOUL_DISABLE_EXTERNAL_WARNINGS)
disable_external_warnings(cfitsio)
disable_external_warnings(CCfits)
endif ()
disable_external_warnings(cfitsio)
disable_external_warnings(CCfits)
target_include_directories(${MODULE_NAME} SYSTEM PUBLIC ${INCLUDES_FOR_TARGET})
target_link_libraries(${MODULE_NAME} PRIVATE CCfits)

2
modules/fitsfilereader/src/fitsfilereader.cpp
View File

@@ -325,7 +325,7 @@ std::vector<float> FitsFileReader::readFitsFile(std::string filePath, int& nValu
values[idx++] = tycho_v_err[i % nStars];
// Read extra columns, if any. This will slow down the sorting tremendously!
for (size_t col = defaultCols; col < nColumnsRead; ++col) {
for (int col = defaultCols; col < nColumnsRead; ++col) {
std::vector<float> vecData = std::move(tableContent[allColumnNames[col]]);
values[idx++] = vecData[i];
}