From 8c7beea8a40b52079168fea26c4b3b2024384ad6 Mon Sep 17 00:00:00 2001 From: Alexander Bock Date: Sat, 15 Apr 2023 10:20:39 +0200 Subject: [PATCH] Reprivatize the registerUpdateRenderBinFromOpacity function --- include/openspace/rendering/renderable.h | 4 ++-- modules/video/src/renderablevideosphere.cpp | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/openspace/rendering/renderable.h b/include/openspace/rendering/renderable.h index 42566c50f6..38f94f62a3 100644 --- a/include/openspace/rendering/renderable.h +++ b/include/openspace/rendering/renderable.h @@ -141,8 +141,6 @@ protected: // An optional renderbin that renderables can use for certain components, in cases // where all parts of the renderable should not be rendered in the same bin std::optional _secondaryRenderBin; - - void registerUpdateRenderBinFromOpacity(); private: double _boundingSphere = 0.0; @@ -152,6 +150,8 @@ private: bool _automaticallyUpdateRenderBin = true; bool _hasOverrideRenderBin = false; + void registerUpdateRenderBinFromOpacity(); + // We only want the SceneGraphNode to be able manipulate the parent, so we don't want // to provide a set method for this. Otherwise, anyone might mess around with our // parentage and that's no bueno diff --git a/modules/video/src/renderablevideosphere.cpp b/modules/video/src/renderablevideosphere.cpp index 2334c00755..9bb108ce2f 100644 --- a/modules/video/src/renderablevideosphere.cpp +++ b/modules/video/src/renderablevideosphere.cpp @@ -148,7 +148,6 @@ RenderableVideoSphere::RenderableVideoSphere(const ghoul::Dictionary& dictionary const Parameters p = codegen::bake(dictionary); addProperty(_opacity); - registerUpdateRenderBinFromOpacity(); _size = p.size; _segments = p.segments;