diff --git a/ext/ghoul b/ext/ghoul index 7cbe2871c8..f0cd30b929 160000 --- a/ext/ghoul +++ b/ext/ghoul @@ -1 +1 @@ -Subproject commit 7cbe2871c85dba64d5341560d8e1ef5d1f57e496 +Subproject commit f0cd30b9293776a09b927cbbb0041f7f45da44cb diff --git a/src/engine/downloadmanager.cpp b/src/engine/downloadmanager.cpp index fc48441157..884831dbdd 100644 --- a/src/engine/downloadmanager.cpp +++ b/src/engine/downloadmanager.cpp @@ -205,7 +205,7 @@ std::vector DownloadManager::downloadRequestFiles( DownloadProgressCallback progressCallback) { std::vector futures; - bool s = FileSys.createDirectory(destination, true); + FileSys.createDirectory(destination, true); // TODO: Check s ---abock // TODO: Escaping is necessary ---abock const std::string fullRequest =_requestURL + "?" + diff --git a/src/engine/openspaceengine.cpp b/src/engine/openspaceengine.cpp index cc16bef537..68b3fd3081 100644 --- a/src/engine/openspaceengine.cpp +++ b/src/engine/openspaceengine.cpp @@ -260,8 +260,7 @@ bool OpenSpaceEngine::create( if (!FileSys.directoryExists(token)) { std::string p = absPath(token); LDEBUG("Directory '" << p << "' does not exist, creating."); - if (!FileSys.createDirectory(p, true)) - LERROR("Directory '" << p << "' could not be created"); + FileSys.createDirectory(p, true); } } diff --git a/src/properties/property.cpp b/src/properties/property.cpp index cb839c9c10..3115fdefc1 100644 --- a/src/properties/property.cpp +++ b/src/properties/property.cpp @@ -115,7 +115,7 @@ bool Property::setStringValue(std::string value) { std::string Property::guiName() const { std::string result; _metaData.getValue(_metaDataKeyGuiName, result); - return std::move(result); + return result; } std::string Property::description() const { @@ -129,7 +129,7 @@ void Property::setGroupIdentifier(std::string groupId) { std::string Property::groupIdentifier() const { std::string result; _metaData.getValue(_metaDataKeyGroup, result); - return std::move(result); + return result; } void Property::setVisible(bool state) { diff --git a/src/properties/propertyowner.cpp b/src/properties/propertyowner.cpp index 3872831d17..ae753170cc 100644 --- a/src/properties/propertyowner.cpp +++ b/src/properties/propertyowner.cpp @@ -67,7 +67,7 @@ std::vector PropertyOwner::propertiesRecursive() const { props.insert(props.end(), p.begin(), p.end()); } - return std::move(props); + return props; } Property* PropertyOwner::property(const std::string& id) const {