mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-04-29 23:39:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

Code Cleanup (#2191)

Browse Source 
* constexpr const -> constexpr
* const char* -> std::string_view
This commit is contained in:
Alexander Bock
2022-07-25 15:57:45 +02:00
committed by GitHub
parent ea1f4bbf40
commit 9cc4c595a8
267 changed files with 1425 additions and 1565 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/openspace/scene/profile.h
+3 -3
View File
@@ -106,7 +106,7 @@ public:
};
struct CameraNavState {
static constexpr const char* Type = "setNavigationState";
static constexpr std::string_view Type = "setNavigationState";
std::string anchor;
std::optional<std::string> aim;
@@ -118,7 +118,7 @@ public:
};
struct CameraGoToGeo {
static constexpr const char* Type = "goToGeo";
static constexpr std::string_view Type = "goToGeo";
std::string anchor;
double latitude;
@@ -146,7 +146,7 @@ public:
/// Removes an asset unless the `ignoreUpdates` member is set to `true`
void removeAsset(const std::string& path);
static constexpr const Version CurrentVersion = Version{ 1, 1 };
static constexpr Version CurrentVersion = Version{ 1, 1 };
Version version = CurrentVersion;
std::vector<Module> modules;
include/openspace/scene/rotation.h
-1
View File
@@ -29,7 +29,6 @@
#include <ghoul/glm.h>
#include <ghoul/misc/managedmemoryuniqueptr.h>
#include <memory>
namespace ghoul { class Dictionary; }
include/openspace/scene/scale.h
-1
View File
@@ -29,7 +29,6 @@
#include <ghoul/glm.h>
#include <ghoul/misc/managedmemoryuniqueptr.h>
#include <memory>
namespace ghoul { class Dictionary; }
include/openspace/scene/scenegraphnode.h
+4 -4
View File
@@ -75,10 +75,10 @@ public:
BooleanType(UpdateScene);
static constexpr const char* RootNodeIdentifier = "Root";
static constexpr const char* KeyIdentifier = "Identifier";
static constexpr const char* KeyParentName = "Parent";
static constexpr const char* KeyDependencies = "Dependencies";
static constexpr const char* KeyTag = "Tag";
static constexpr std::string_view KeyIdentifier = "Identifier";
static constexpr std::string_view KeyParentName = "Parent";
static constexpr std::string_view KeyDependencies = "Dependencies";
static constexpr std::string_view KeyTag = "Tag";
SceneGraphNode();
virtual ~SceneGraphNode() override;
include/openspace/scene/translation.h
-2
View File
@@ -29,9 +29,7 @@
#include <ghoul/glm.h>
#include <ghoul/misc/managedmemoryuniqueptr.h>
#include <functional>
#include <memory>
namespace ghoul { class Dictionary; }