mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-01-06 03:29:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

Code Cleanup (#2191)

Browse Source 
* constexpr const -> constexpr
* const char* -> std::string_view
This commit is contained in:
Alexander Bock
2022-07-25 15:57:45 +02:00
committed by GitHub
parent ea1f4bbf40
commit 9cc4c595a8
267 changed files with 1425 additions and 1565 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/base/dashboard/dashboarditemparallelconnection.cpp
View File

@@ -63,8 +63,8 @@ void DashboardItemParallelConnection::render(glm::vec2& penPosition) {
int nClients = static_cast<int>(nConnections);
if (status == ParallelConnection::Status::Host) {
nClients--;
constexpr const char* Singular = "Hosting session with {} client";
constexpr const char* Plural = "Hosting session with {} clients";
constexpr std::string_view Singular = "Hosting session with {} client";
constexpr std::string_view Plural = "Hosting session with {} clients";
connectionInfo =
(nClients == 1) ?
@@ -85,11 +85,11 @@ void DashboardItemParallelConnection::render(glm::vec2& penPosition) {
connectionInfo += "\n";
if (nClients > 2) {
constexpr const char* Plural = "You and {} more clients are tuned in";
constexpr std::string_view Plural = "You and {} more clients are tuned in";
connectionInfo += fmt::format(Plural, nClients - 1);
}
else if (nClients == 2) {
constexpr const char* Singular = "You and {} more client are tuned in";
constexpr std::string_view Singular = "You and {} more client are tuned in";
connectionInfo += fmt::format(Singular, nClients - 1);
}
else if (nClients == 1) {
@@ -136,11 +136,11 @@ glm::vec2 DashboardItemParallelConnection::size() const {
{
connectionInfo += "\n";
if (nClients > 2) {
constexpr const char* Plural = "You and {} more clients are tuned in";
constexpr std::string_view Plural = "You and {} more clients are tuned in";
connectionInfo += fmt::format(Plural, nClients);
}
else if (nClients == 2) {
constexpr const char* Singular = "You and {} more client are tuned in";
constexpr std::string_view Singular = "You and {} more client are tuned in";
connectionInfo += fmt::format(Singular, nClients - 1);
}
else if (nClients == 1) {