Code Cleanup (#2191)

* constexpr const -> constexpr
* const char* -> std::string_view

modules/exoplanets/exoplanetsmodule.cpp

@@ -51,98 +51,88 @@
 #include "exoplanetsmodule_lua.inl"
 
 namespace {
-    constexpr const openspace::properties::Property::PropertyInfo EnabledInfo = {
+    constexpr openspace::properties::Property::PropertyInfo EnabledInfo = {
         "Enabled",
         "Enabled",
         "Decides if the GUI for this module should be enabled."
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo DataFolderInfo = {
+    constexpr openspace::properties::Property::PropertyInfo DataFolderInfo = {
         "DataFolder",
         "Data Folder",
         "The path to the folder containing the exoplanets data and lookup table"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo BvColorMapInfo = {
+    constexpr openspace::properties::Property::PropertyInfo BvColorMapInfo = {
         "BvColormap",
         "B-V Colormap",
         "The path to a cmap file that maps a B-V color index to an RGB color"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo StarTextureInfo = {
+    constexpr openspace::properties::Property::PropertyInfo StarTextureInfo = {
         "StarTexture",
         "Star Texture",
         "The path to a grayscale image that is used for the host star surfaces"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo StarGlareTextureInfo = {
+    constexpr openspace::properties::Property::PropertyInfo StarGlareTextureInfo = {
         "StarGlareTexture",
         "Star Glare Texture",
         "The path to a grayscale image that is used for the glare effect of the "
         "host stars"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo NoDataTextureInfo = {
+    constexpr openspace::properties::Property::PropertyInfo NoDataTextureInfo = {
         "NoDataTexture",
         "No Data Star Texture",
         "A path to a texture that is used to represent that there is missing data about "
         "the star. For example no color information"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo OrbitDiscTextureInfo =
-    {
+    constexpr openspace::properties::Property::PropertyInfo OrbitDiscTextureInfo = {
         "OrbitDiscTexture",
         "Orbit Disc Texture",
         "A path to a 1-dimensional image used as a transfer function for the "
         "exoplanets' orbit uncertainty disc"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo
-        HabitableZoneTextureInfo =
-    {
+    constexpr openspace::properties::Property::PropertyInfo HabitableZoneTextureInfo = {
         "HabitableZoneTexture",
         "Habitable Zone Texture",
         "A path to a 1-dimensional image used as a transfer function for the "
         "habitable zone disc"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo
-        ShowComparisonCircleInfo =
-    {
+    constexpr openspace::properties::Property::PropertyInfo ShowComparisonCircleInfo = {
         "ShowComparisonCircle",
         "Show Comparison Circle",
         "If true, the 1 AU size comparison circle is enabled per default when an "
         "exoplanet system is created"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo
-        ShowHabitableZoneInfo =
-    {
+    constexpr openspace::properties::Property::PropertyInfo ShowHabitableZoneInfo = {
         "ShowHabitableZone",
         "Show Habitable Zone",
         "If true, the habitable zone disc is enabled per default when an "
         "exoplanet system is created"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo UseOptimisticZoneInfo =
-    {
+    constexpr openspace::properties::Property::PropertyInfo UseOptimisticZoneInfo = {
         "UseOptimisticZone",
         "Use Optimistic Zone Boundaries",
         "If true, the habitable zone is computed with optimistic boundaries per default "
         "when an exoplanet system is created"
     };
 
-    constexpr const openspace::properties::Property::PropertyInfo
-        HabitableZoneOpacityInfo =
-    {
+    constexpr openspace::properties::Property::PropertyInfo HabitableZoneOpacityInfo = {
         "HabitableZoneOpacity",
         "Habitable Zone Opacity",
         "The opacity value used for the habitable zone renderable for a created "
         "exoplanet system"
     };
 
-    constexpr const char ExoplanetsDataFileName[] = "exoplanets_data.bin";
-    constexpr const char LookupTableFileName[] = "lookup.txt";
+    constexpr std::string_view ExoplanetsDataFileName = "exoplanets_data.bin";
+    constexpr std::string_view LookupTableFileName = "lookup.txt";
 
     struct [[codegen::Dictionary(ExoplanetsModule)]] Parameters {
         // [[codegen::verbatim(EnabledInfo.description)]]