mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-05-06 11:29:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

Code Cleanup (#2191)

Browse Source 
* constexpr const -> constexpr
* const char* -> std::string_view
This commit is contained in:
Alexander Bock
2022-07-25 15:57:45 +02:00
committed by GitHub
parent ea1f4bbf40
commit 9cc4c595a8
267 changed files with 1425 additions and 1565 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/spacecraftinstruments/rendering/renderableplaneprojection.cpp
+5 -6
View File
@@ -42,8 +42,7 @@
#include <glm/gtx/projection.hpp>
namespace {
constexpr const char* _loggerCat = "RenderablePlaneProjection";
constexpr const char* GalacticFrame = "GALACTIC";
constexpr std::string_view _loggerCat = "RenderablePlaneProjection";
struct [[codegen::Dictionary(RenderablePlaneProjection)]] Parameters {
// The SPICE name of the spacecraft from which the projection is performed
@@ -154,7 +153,7 @@ void RenderablePlaneProjection::update(const UpdateData& data) {
_stateMatrix = SpiceManager::ref().positionTransformMatrix(
_target.frame,
GalacticFrame,
"GALACTIC",
time
);
@@ -224,7 +223,7 @@ void RenderablePlaneProjection::updatePlane(const Image& img, double currentTime
const glm::dvec3 vecToTarget = SpiceManager::ref().targetPosition(
_target.body,
_spacecraft,
GalacticFrame,
"GALACTIC",
{
SpiceManager::AberrationCorrection::Type::ConvergedNewtonianStellar,
SpiceManager::AberrationCorrection::Direction::Reception
@@ -239,14 +238,14 @@ void RenderablePlaneProjection::updatePlane(const Image& img, double currentTime
for (size_t j = 0; j < bounds.size(); ++j) {
bounds[j] = SpiceManager::ref().frameTransformationMatrix(
frame,
GalacticFrame,
"GALACTIC",
currentTime
) * bounds[j];
glm::dvec3 cornerPosition = glm::proj(vecToTarget, bounds[j]);
cornerPosition -= vecToTarget;
cornerPosition = SpiceManager::ref().frameTransformationMatrix(
GalacticFrame,
"GALACTIC",
_target.frame,
currentTime
) * cornerPosition;