From a017006ec60ae5dbb6b3b64078d7c45364e4ab92 Mon Sep 17 00:00:00 2001 From: Malin E Date: Thu, 13 Apr 2023 12:35:51 +0200 Subject: [PATCH] Add todo comment from discussion in PR --- modules/base/rendering/renderablemodel.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/base/rendering/renderablemodel.cpp b/modules/base/rendering/renderablemodel.cpp index 2479ca13c0..db610f75e9 100644 --- a/modules/base/rendering/renderablemodel.cpp +++ b/modules/base/rendering/renderablemodel.cpp @@ -682,6 +682,9 @@ void RenderableModel::render(const RenderData& data, RendererTasks&) { // Formula from RenderableGlobe constexpr double tfov = 0.5773502691896257; constexpr int res = 2880; + + // @TODO (malej 13-APR-23): This should only use the boundingSphere function once + // that takes the gui scale into account too for all renderables const double maxDistance = res * boundingSphere() * glm::compMax(data.modelTransform.scale) / tfov;