From b7c566089b9dcbee34de90da45bbd3693a1e91e2 Mon Sep 17 00:00:00 2001 From: Micah Acinapura Date: Tue, 13 Oct 2020 06:06:26 -0400 Subject: [PATCH] fixes to cmake for macos --- apps/Sync/CMakeLists.txt | 2 +- apps/TaskRunner/CMakeLists.txt | 2 +- modules/webbrowser/cmake/webbrowser_helpers.cmake | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/Sync/CMakeLists.txt b/apps/Sync/CMakeLists.txt index 57b41bce3e..71bfbf3859 100644 --- a/apps/Sync/CMakeLists.txt +++ b/apps/Sync/CMakeLists.txt @@ -37,7 +37,7 @@ create_new_application(Sync MACOSX_BUNDLE ${CMAKE_CURRENT_SOURCE_DIR}/openspace.icns ) -target_link_libraries(Sync openspace-core) +target_link_libraries(Sync PUBLIC openspace-core) # Web Browser and Web gui # Why not put these in the module's path? Because they do not have access to the diff --git a/apps/TaskRunner/CMakeLists.txt b/apps/TaskRunner/CMakeLists.txt index e5eba87469..8fa2b9bbd1 100644 --- a/apps/TaskRunner/CMakeLists.txt +++ b/apps/TaskRunner/CMakeLists.txt @@ -37,7 +37,7 @@ create_new_application(TaskRunner MACOSX_BUNDLE ${CMAKE_CURRENT_SOURCE_DIR}/openspace.icns ) -target_link_libraries(TaskRunner openspace-core) +target_link_libraries(TaskRunner PUBLIC openspace-core) # Web Browser and Web gui # Why not put these in the module's path? Because they do not have access to the diff --git a/modules/webbrowser/cmake/webbrowser_helpers.cmake b/modules/webbrowser/cmake/webbrowser_helpers.cmake index 6aaf6b3166..ac082325ba 100644 --- a/modules/webbrowser/cmake/webbrowser_helpers.cmake +++ b/modules/webbrowser/cmake/webbrowser_helpers.cmake @@ -77,7 +77,7 @@ function(run_cef_macosx_config CEF_ROOT module_path) add_dependencies(${CEF_TARGET} libcef_dll_wrapper "${CEF_HELPER_TARGET}") - target_link_libraries(${CEF_TARGET} libcef_lib libcef_dll_wrapper ${CEF_STANDARD_LIBS}) + target_link_libraries(${CEF_TARGET} PUBLIC libcef_lib libcef_dll_wrapper ${CEF_STANDARD_LIBS}) set_target_properties(${CEF_TARGET} PROPERTIES RESOURCE "${WEBBROWSER_RESOURCES_SRCS}" MACOSX_BUNDLE_INFO_PLIST ${module_path}/mac/Info.plist