mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-04-28 06:49:32 -05:00
Code Issues Packages Projects Releases Wiki Activity

Allow sessionrecording to write a file outside of user/recordings/ (#3150)

Browse Source
This commit is contained in:
Gene Payne
2024-04-07 10:38:17 -06:00
committed by GitHub
parent 2a88521795
commit bd82000308
1 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/interaction/sessionrecording.cpp
+15 -6
View File
@@ -157,11 +157,6 @@ void SessionRecording::removeTrailingPathSlashes(std::string& filename) const {
}
bool SessionRecording::handleRecordingFile(std::string filenameIn) {
if (isPath(filenameIn)) {
LERROR("Recording filename must not contain path (/) elements");
return false;
}
if (_recordingDataMode == DataMode::Binary) {
if (hasFileExtension(filenameIn, FileExtensionAscii)) {
LERROR("Specified filename for binary recording has ascii file extension");
@@ -181,7 +176,21 @@ bool SessionRecording::handleRecordingFile(std::string filenameIn) {
}
}
std::filesystem::path absFilename = absPath("${RECORDINGS}/" + filenameIn);
std::filesystem::path absFilename = filenameIn;
if (absFilename.parent_path().empty() || absFilename.parent_path() == absFilename) {
absFilename = absPath("${RECORDINGS}/" + filenameIn);
}
else if (absFilename.parent_path().is_relative()) {
LERROR("If path is provided with the filename, then it must be an absolute path");
return false;
}
else if (!std::filesystem::exists(absFilename.parent_path())) {
LERROR(std::format(
"The recording filename path '{}' is not a valid location in the filesytem",
absFilename.parent_path().string()
));
return false;
}
if (std::filesystem::is_regular_file(absFilename)) {
LERROR(std::format(