mirror/OpenSpace
1
0
Fork 0
mirror of https://github.com/OpenSpace/OpenSpace.git synced 2026-01-05 19:19:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Address PR comments

Browse Source
This commit is contained in:
Malin E
2023-04-13 14:54:49 +02:00
parent a017006ec6
commit c2457e5c41
1 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
modules/base/rendering/renderablemodel.cpp
View File

@@ -786,17 +786,11 @@ void RenderableModel::render(const RenderData& data, RendererTasks&) {
if (hasOverrideRenderBin()) {
// If override render bin is set then use the opacity values as normal
_program->setUniform(
_uniformCache.opacity,
opacity()
);
_program->setUniform(_uniformCache.opacity, opacity());
}
else {
// Otherwise reset
_program->setUniform(
_uniformCache.opacity,
1.f
);
// Otherwise reset to 1
_program->setUniform(_uniformCache.opacity, 1.f);
}
_geometry->render(*_program);
@@ -851,10 +845,7 @@ void RenderableModel::render(const RenderData& data, RendererTasks&) {
);
// Make sure opacity in first pass is always 1
_program->setUniform(
_uniformCache.opacity,
1.f
);
_program->setUniform(_uniformCache.opacity, 1.f);
// Render Pass 1
// Render all parts of the model into the new framebuffer without opacity